Merged
Conversation
Contributor
Author
|
(Failing tests are addressed in #30. Will not fix here.) |
cpsievert
approved these changes
Jan 8, 2025
| port: int = 0, | ||
| launch_browser: bool = True, | ||
| bg_thread: Optional[bool] = None, | ||
| echo: Optional[Literal["text", "all", "none"]] = None, |
Contributor
There was a problem hiding this comment.
Given how this is being used below, could be cleaner to default this to "none". I forget now the previous default behavior but would none be preferred over text for both cases (stream = True/False) unless explicitly set by the user?
Contributor
Author
There was a problem hiding this comment.
In stream=False, the default is "text". But for stream=True, the default is "none".
With the conflicting behavior, I set the default to None (which goes to the appropriate default value given stream's value).
* main: bug: Use `repr()` for chat tool calls when exporting markdown (#30)
Contributor
Author
|
Failing test is unrelated to changes. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional changes:
echo=to be able to expose tool calls within the app.cc @mconflitti-pbc