Skip to content

Conversation

@linkmauve
Copy link
Contributor

@linkmauve linkmauve commented Oct 31, 2025

These are mostly more lifetime elisions, and Option::is_some_and(f) replacing Option::map(false, f), see: https://github.com/pest-parser/pest/actions/runs/18968907018/job/54188036314

Fixes CI.

Summary by CodeRabbit

  • Refactor
    • Generalized internal lifetime parameters across iterator and utility types, broadening their applicability without changing observable behavior.
    • Simplified method signature handling to improve code maintainability and flexibility.

These are mostly more lifetime elisions, and Option::is_some_and(f)
replacing Option::map(false, f), see:
https://github.com/pest-parser/pest/actions/runs/18968907018/job/54188036314

Fixes CI.
@linkmauve linkmauve requested a review from a team as a code owner October 31, 2025 13:48
@linkmauve linkmauve requested review from tomtau and removed request for a team October 31, 2025 13:48
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 31, 2025

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

📥 Commits

Reviewing files that changed from the base of the PR and between c51e047 and 6e7a4e1.

📒 Files selected for processing (7)
  • pest/src/iterators/flat_pairs.rs (3 hunks)
  • pest/src/iterators/pair.rs (4 hunks)
  • pest/src/iterators/pairs.rs (5 hunks)
  • pest/src/iterators/tokens.rs (3 hunks)
  • pest/src/parser_state.rs (1 hunks)
  • pest/src/position.rs (3 hunks)
  • pest/src/span.rs (2 hunks)
 _______________________________________________________________________________________________________
< Start when you're ready. You've been building experience all your life. Don't ignore niggling doubts. >
 -------------------------------------------------------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ

Tip

CodeRabbit can enforce grammar and style rules using `languagetool`.

Configure languagetool in your project's settings in CodeRabbit enable/disable rules and categories. Refer to the LanguageTool Community to learn more.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@linkmauve linkmauve mentioned this pull request Oct 31, 2025
@tomtau tomtau merged commit 27f7ed1 into pest-parser:master Oct 31, 2025
8 of 9 checks passed
@linkmauve linkmauve deleted the fix-clippy branch October 31, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants