Skip to content

Conversation

@linkmauve
Copy link
Contributor

@linkmauve linkmauve commented Oct 31, 2025

pest_meta depends on cargo which depends on url which depends on idna which depends on icu, and icu bumped its MSRV to 1.83 in their 2.1.1 release, which makes CI fail atm:
https://github.com/pest-parser/pest/actions/runs/18951021123/job/54140212074?pr=1133

I think it makes more sense to follow our dependencies’ MSRV than to pin them to a specific older version, especially since our previous MSRV was so close (1.82.0).

Summary by CodeRabbit

  • Chores

    • Updated minimum Rust toolchain requirement to 1.83 across the project.
  • Chores / CI

    • Updated CI and release workflows to use Rust toolchain 1.83.
  • Documentation

    • Updated README and status badges to reflect Rust 1.83.

pest_meta depends on cargo which depends on url which depends on idna
which depends on icu, and icu bumped its MSRV to 1.83 in their 2.1.1
release, which makes CI fail atm:
https://github.com/pest-parser/pest/actions/runs/18951021123/job/54140212074?pr=1133
To match the previous commit, let’s use Rust 1.83.0 as the oldest
supported release in CI.
@linkmauve linkmauve requested a review from a team as a code owner October 31, 2025 09:50
@linkmauve linkmauve requested review from tomtau and removed request for a team October 31, 2025 09:50
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 31, 2025

Walkthrough

The PR updates declared Rust toolchain versions from 1.80/1.81/1.82 to 1.83 across GitHub Actions workflows and crate Cargo.toml manifests; README badges were updated to reflect the new MSRV. No functional code or dependency changes were made.

Changes

Cohort / File(s) Summary
CI / Release Workflows
.github/workflows/ci.yml, .github/workflows/release.yml
Updated GitHub Actions Rust toolchain setup from 1.82.01.83.0 in CI and release workflows.
Crate Manifests (rust-version bumps)
bootstrap/Cargo.toml, debugger/Cargo.toml, derive/Cargo.toml, generator/Cargo.toml, grammars/Cargo.toml, grammars/fuzz/Cargo.toml, meta/Cargo.toml, meta/fuzz/Cargo.toml, pest/Cargo.toml, vm/Cargo.toml
Bumped package.rust-version / rust-version fields from 1.80/1.811.83 across crate manifests. No dependency or code changes.
Documentation
README.md
Updated reported MSRV and rustc badge versions to 1.83.0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Pay attention to consistent updates of rust-version fields and CI steps to avoid missed files.
  • Verify README badge links/versions match the new MSRV.

Possibly related PRs

Suggested reviewers

  • NoahTheDuke

Poem

🐰 I hopped from eighty-two to eighty-three,
Bumped manifests and workflows — light and free.
Badges shining, toolchain set anew,
A tiny hop for me, a steady cue.
Rust gardens grow; I nibble and review. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "Bump MSRV" directly and accurately describes the primary change in the changeset. The entire PR updates the Minimum Supported Rust Version from 1.82.0 to 1.83.0 across GitHub workflows, multiple Cargo.toml files (bootstrap, debugger, derive, generator, grammars, meta, pest, vm), and the README.md. The title is concise, specific to the Rust ecosystem (MSRV is a well-understood term), and clearly conveys the main objective without being vague or misleading.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 751a25d and d7e0d3c.

📒 Files selected for processing (1)
  • README.md (2 hunks)
🔇 Additional comments (2)
README.md (2)

205-205: MSRV bump is consistent across documentation and toolchain updates.

The MSRV statement correctly reflects the 1.83.0 bump, aligning with the badge update on line 14 and the broader toolchain updates across the repository's Cargo.toml files and CI workflows (confirmed in enriched summary). The version bump is justified by the icu crate's MSRV requirement in the dependency chain.


14-14: URL is valid—no changes needed.

The badge URL correctly references the official Rust 1.83.0 release announcement at https://blog.rust-lang.org/2024/11/28/Rust-1.83.0/. The MSRV bump is accurate and consistent across the README.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you also update MSRV in README?

The badge and the text were desynchronized, plus the badge pointed to a
404 blog post.

I’ve fixed both to point to 1.83.0.
@linkmauve
Copy link
Contributor Author

linkmauve commented Oct 31, 2025

Just did, thanks!

Edit: I’ve also done #1135 to fix the CI fail caused by clippy.

@tomtau tomtau merged commit 11f45aa into pest-parser:master Oct 31, 2025
8 of 9 checks passed
@linkmauve linkmauve deleted the bump-msrv branch November 3, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants