-
-
Notifications
You must be signed in to change notification settings - Fork 285
Bump MSRV #1134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump MSRV #1134
Conversation
pest_meta depends on cargo which depends on url which depends on idna which depends on icu, and icu bumped its MSRV to 1.83 in their 2.1.1 release, which makes CI fail atm: https://github.com/pest-parser/pest/actions/runs/18951021123/job/54140212074?pr=1133
To match the previous commit, let’s use Rust 1.83.0 as the oldest supported release in CI.
WalkthroughThe PR updates declared Rust toolchain versions from 1.80/1.81/1.82 to 1.83 across GitHub Actions workflows and crate Cargo.toml manifests; README badges were updated to reflect the new MSRV. No functional code or dependency changes were made. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tomtau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you also update MSRV in README?
The badge and the text were desynchronized, plus the badge pointed to a 404 blog post. I’ve fixed both to point to 1.83.0.
|
Just did, thanks! Edit: I’ve also done #1135 to fix the CI fail caused by clippy. |
pest_metadepends oncargowhich depends onurlwhich depends onidnawhich depends onicu, andicubumped its MSRV to 1.83 in their 2.1.1 release, which makes CI fail atm:https://github.com/pest-parser/pest/actions/runs/18951021123/job/54140212074?pr=1133
I think it makes more sense to follow our dependencies’ MSRV than to pin them to a specific older version, especially since our previous MSRV was so close (1.82.0).
Summary by CodeRabbit
Chores
Chores / CI
Documentation