Skip to content

feat: impl Error from core #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tomtau merged 2 commits into from
Sep 19, 2025
+12 −14
Merged

feat: impl Error from core #1121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04c061f
feat: impl Error from core
CosmicHorrorDev Sep 19, 2025
815c440
docs: Update MSRV to 1.81.0 across the workspace
CosmicHorrorDev Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ You can find more projects and ecosystem tools in the [awesome-pest](https://git

## Minimum Supported Rust Version (MSRV)

This library should always compile with default features on **Rust 1.80.0**.
This library should always compile with default features on **Rust 1.81.0**.

## no_std support

Expand Down
4 changes: 2 additions & 2 deletions bootstrap/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ repository = "https://github.com/pest-parser/pest"
documentation = "https://docs.rs/pest"
publish = false
license = "MIT OR Apache-2.0"
rust-version = "1.80"
rust-version = "1.81"

[dependencies]
pest_generator = "2.1.1" # Use the crates-io version, which (should be) known-good
Expand All @@ -19,4 +19,4 @@ quote = "1.0"
default = []
# Whether or not the bootstrapper should put the generated .rs file in the
# source tree or in the output tree
not-bootstrap-in-src = []
not-bootstrap-in-src = []
2 changes: 1 addition & 1 deletion debugger/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ keywords = ["pest", "grammar", "debugger"]
categories = ["parsing"]
license = "MIT OR Apache-2.0"
readme = "_README.md"
rust-version = "1.80"
rust-version = "1.81"

[dependencies]
pest = { path = "../pest", version = "2.8.2" }
Expand Down
2 changes: 1 addition & 1 deletion derive/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ keywords = ["pest", "parser", "peg", "grammar"]
categories = ["parsing"]
license = "MIT OR Apache-2.0"
readme = "_README.md"
rust-version = "1.80"
rust-version = "1.81"

[lib]
name = "pest_derive"
Expand Down
2 changes: 1 addition & 1 deletion generator/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ keywords = ["pest", "generator"]
categories = ["parsing"]
license = "MIT OR Apache-2.0"
readme = "_README.md"
rust-version = "1.80"
rust-version = "1.81"

[features]
default = ["std"]
Expand Down
2 changes: 1 addition & 1 deletion grammars/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ keywords = ["pest", "parser", "peg", "grammar"]
categories = ["parsing"]
license = "MIT OR Apache-2.0"
readme = "_README.md"
rust-version = "1.80"
rust-version = "1.81"

[dependencies]
pest = { path = "../pest", version = "2.8.2" }
Expand Down
2 changes: 1 addition & 1 deletion meta/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ include = [
"_README.md",
"LICENSE-*",
]
rust-version = "1.80"
rust-version = "1.81"

[dependencies]
pest = { path = "../pest", version = "2.8.2" }
Expand Down
2 changes: 1 addition & 1 deletion pest/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ keywords = ["pest", "parser", "peg", "grammar"]
categories = ["parsing"]
license = "MIT OR Apache-2.0"
readme = "_README.md"
rust-version = "1.80"
rust-version = "1.81"

[features]
default = ["std", "memchr"]
Expand Down
6 changes: 2 additions & 4 deletions pest/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ pub struct Error<R> {
parse_attempts: Option<ParseAttempts<R>>,
}

#[cfg(feature = "std")]
impl<R: RuleType> core::error::Error for Error<R> {}

/// Different kinds of parsing errors.
Expand All @@ -62,8 +61,7 @@ pub enum ErrorVariant<R> {
},
}

#[cfg(feature = "std")]
impl<R: RuleType> std::error::Error for ErrorVariant<R> {}
impl<R: RuleType> core::error::Error for ErrorVariant<R> {}

/// Where an `Error` has occurred.
#[derive(Clone, Debug, Eq, Hash, PartialEq)]
Expand Down Expand Up @@ -784,7 +782,7 @@ mod miette_adapter {
}
}

impl<R> std::error::Error for MietteAdapter<R>
impl<R> core::error::Error for MietteAdapter<R>
where
R: RuleType,
Self: fmt::Debug + fmt::Display,
Expand Down
2 changes: 1 addition & 1 deletion vm/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ keywords = ["pest", "vm"]
categories = ["parsing"]
license = "MIT OR Apache-2.0"
readme = "_README.md"
rust-version = "1.80"
rust-version = "1.81"

[dependencies]
pest = { path = "../pest", version = "2.8.2" }
Expand Down
Loading