feat: impl Error from core #1121
Merged
+12
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CosmicHorrorDev
requested review from
tomtau
and removed request for
a team
tomtau
requested changes
Sep 19, 2025
Contributor
tomtau
left a comment
tomtau
left a comment
There was a problem hiding this comment.
Thanks! Could you also update the MSRV in README and in other pest crates which depend on the pest crate?
Contributor
Author
|
Done! |
tomtau
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1120. This switches to using
core::error::Errorand bumps the MSRV up to 1.81 to match. It looks like all of CI was already using at least 1.82, so I don't think that requires any additional changes