Skip to content

fix: close HTTP response body before following redirects #6183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jaffarkeikei wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: close HTTP response body before following redirects #6183

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c5d7ce6
fix: close HTTP response body before following redirects
jaffarkeikei Jan 29, 2026
1be4248
fix: close response body on too many redirects error
jaffarkeikei Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/debuginfo/debuginfod.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,9 @@ func (c *HTTPDebuginfodClient) handleResponse(ctx context.Context, resp *http.Re
case 2:
return resp.Body, nil
case 3:
resp, err = c.doRequest(ctx, resp.Header.Get("Location"))
redirectURL := resp.Header.Get("Location")
resp.Body.Close() // Close old response before redirect
resp, err = c.doRequest(ctx, redirectURL)
if err != nil {
return nil, fmt.Errorf("request failed: %w", err)
}
Expand All @@ -425,6 +427,8 @@ func (c *HTTPDebuginfodClient) handleResponse(ctx context.Context, resp *http.Re
}
}

// Close the response body before returning error for too many redirects
resp.Body.Close()
return nil, errors.New("too many redirects")
}

Expand Down
Loading