fix: close HTTP response body before following redirects #6183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes the old response body before making a new redirect request to prevent resource leaks (file descriptors and memory). Fixes parca-dev#6182
|
|
brancz
approved these changes
Jan 29, 2026
When the redirect loop exits after reaching the maximum number of redirects (2), we were returning an error without closing the last response body, causing a resource leak. This adds resp.Body.Close() before returning the 'too many redirects' error to ensure the response body is properly closed in all code paths. Fixes the test failure on amd64 architecture. Signed-off-by: jaffar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes the old response body before making a new redirect request to prevent resource leaks.
Before:
After:
Impact: Prevents file descriptor and memory leaks when debuginfod servers return redirects.
Fixes #6182