CNV-78917: Use versioned type name for the HyperConverged type#109992
CNV-78917: Use versioned type name for the HyperConverged type#109992sjhala-ccs merged 1 commit intoopenshift:mainfrom
Conversation
|
@nunnatsa: This pull request references CNV-78917 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
🤖 Tue Apr 14 08:36:56 - Prow CI generated the docs preview: |
@nunnatsa You can see the list of preview urls for all distros at the link above. I randomly checked a few for openshift-enterprise, the attributes resolve correctly for some and not for others. For example, the attributes render correctly for |
752514f to
63c70b5
Compare
In v4.22, we are intrucing a new API version for the HyperConverged type (A.K.A hco or hyperconverged). This version is not the default one in v4.22, but because of the way kubernetes works, any non-versioned request of this type (get/edit/patch...), will use the newest API version, regadless if it's the default one or not. This breaks many examples or intructions in the documentation. To solve this, we'll use a versioned name of the HyperConverged type. To ease that, this PR defined a new attibute named `HCOCliKind`, with the value of `hyperconvergeds.v1beta1.hco.kubevirt.io`. Then the PR replaces any read or write command line operation with `hco` or `hyperconverged`, with the new attribute. This will also ease the fix in future release, to get it back to the shorter, non-versioned name. Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>
|
@nunnatsa: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@nunnatsa: This pull request references CNV-78917 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherrypick enterprise-4.22 |
|
@sjhala-ccs: new pull request created: #110041 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
In v4.22, we are intrucing a new API version for the HyperConverged type (A.K.A hco or hyperconverged). This version is not the default one in v4.22, but because of the way kubernetes works, any non-versioned request of this type (get/edit/patch...), will use the newest API version, regadless if it's the default one or not.
This breaks many examples or intructions in the documentation.
To solve this, we'll use a versioned name of the HyperConverged type. To ease that, this PR defined a new attibute named
HCOCliKind, with the value ofhyperconvergeds.v1beta1.hco.kubevirt.io. Then the PR replaces any read or write command line operation withhcoorhyperconverged, with the new attribute.This will also ease the fix in future release, to get it back to the shorter, non-versioned name.
Version(s):
v4.22
Issue:
https://redhat.atlassian.net/browse/CNV-78917
Link to docs preview:
QE review:
Additional information: