Skip to content

CNV-78917: Use versioned type name for the HyperConverged type#109992

Merged
sjhala-ccs merged 1 commit intoopenshift:mainfrom
nunnatsa:hco-v1-4.22
Apr 14, 2026
Merged

CNV-78917: Use versioned type name for the HyperConverged type#109992
sjhala-ccs merged 1 commit intoopenshift:mainfrom
nunnatsa:hco-v1-4.22

Conversation

@nunnatsa
Copy link
Copy Markdown
Contributor

@nunnatsa nunnatsa commented Apr 13, 2026

In v4.22, we are intrucing a new API version for the HyperConverged type (A.K.A hco or hyperconverged). This version is not the default one in v4.22, but because of the way kubernetes works, any non-versioned request of this type (get/edit/patch...), will use the newest API version, regadless if it's the default one or not.

This breaks many examples or intructions in the documentation.

To solve this, we'll use a versioned name of the HyperConverged type. To ease that, this PR defined a new attibute named HCOCliKind, with the value of hyperconvergeds.v1beta1.hco.kubevirt.io. Then the PR replaces any read or write command line operation with hco or hyperconverged, with the new attribute.

This will also ease the fix in future release, to get it back to the shorter, non-versioned name.

Version(s):
v4.22

Issue:
https://redhat.atlassian.net/browse/CNV-78917

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 13, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 13, 2026

@nunnatsa: This pull request references CNV-78917 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

In v4.22, we are intrucing a new API version for the HyperConverged type (A.K.A hco or hyperconverged). This version is not the default one in v4.22, but because of the way kubernetes works, any non-versioned request of this type (get/edit/patch...), will use the newest API version, regadless if it's the default one or not.

This breaks many examples or intructions in the documentation.

To solve this, we'll use a versioned name of the HyperConverged type. To ease that, this PR defined a new attibute named HCOCliKind, with the value of hyperconvergeds.v1beta1.hco.kubevirt.io. Then the PR replaces any read or write command line operation with hco or hyperconverged, with the new attribute.

This will also ease the fix in future release, to get it back to the shorter, non-versioned name.

Version(s):
v4.22

Issue:
https://redhat.atlassian.net/browse/CNV-78917

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 13, 2026
@ocpdocs-previewbot
Copy link
Copy Markdown

ocpdocs-previewbot commented Apr 13, 2026

🤖 Tue Apr 14 08:36:56 - Prow CI generated the docs preview:
https://109992--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

Copy link
Copy Markdown
Contributor

@sjhala-ccs sjhala-ccs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (checking previews now)

@sjhala-ccs
Copy link
Copy Markdown
Contributor

🤖 Mon Apr 13 15:51:04 - Prow CI generated the docs preview: https://109992--ocpdocs-pr.netlify.app Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@nunnatsa You can see the list of preview urls for all distros at the link above. I randomly checked a few for openshift-enterprise, the attributes resolve correctly for some and not for others. For example, the attributes render correctly for
https://109992--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/live_migration/virt-configuring-live-migration#virt-configuring-live-migration-limits_virt-configuring-live-migration but not for
https://109992--ocpdocs-pr.netlify.app/openshift-enterprise/latest/virt/vm_networking/virt-connecting-vm-to-primary-udn#virt-attaching-vm-to-primary-udn_virt-connecting-vm-to-primary-udn

@nunnatsa nunnatsa force-pushed the hco-v1-4.22 branch 3 times, most recently from 752514f to 63c70b5 Compare April 14, 2026 06:57
In v4.22, we are intrucing a new API version for the HyperConverged type
(A.K.A hco or hyperconverged). This version is not the default one in
v4.22, but because of the way kubernetes works, any non-versioned
request of this type (get/edit/patch...), will use the newest API
version, regadless if it's the default one or not.

This breaks many examples or intructions in the documentation.

To solve this, we'll use a versioned name of the HyperConverged type. To
ease that, this PR defined a new attibute named `HCOCliKind`, with the
value of `hyperconvergeds.v1beta1.hco.kubevirt.io`. Then the PR replaces
any read or write command line operation with `hco` or `hyperconverged`,
with the new attribute.

This will also ease the fix in future release, to get it back to the
shorter, non-versioned name.

Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 14, 2026

@nunnatsa: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 14, 2026

@nunnatsa: This pull request references CNV-78917 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

In v4.22, we are intrucing a new API version for the HyperConverged type (A.K.A hco or hyperconverged). This version is not the default one in v4.22, but because of the way kubernetes works, any non-versioned request of this type (get/edit/patch...), will use the newest API version, regadless if it's the default one or not.

This breaks many examples or intructions in the documentation.

To solve this, we'll use a versioned name of the HyperConverged type. To ease that, this PR defined a new attibute named HCOCliKind, with the value of hyperconvergeds.v1beta1.hco.kubevirt.io. Then the PR replaces any read or write command line operation with hco or hyperconverged, with the new attribute.

This will also ease the fix in future release, to get it back to the shorter, non-versioned name.

Version(s):
v4.22

Issue:
https://redhat.atlassian.net/browse/CNV-78917

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sjhala-ccs sjhala-ccs merged commit 0e1839f into openshift:main Apr 14, 2026
2 checks passed
@sjhala-ccs
Copy link
Copy Markdown
Contributor

/cherrypick enterprise-4.22

@openshift-cherrypick-robot
Copy link
Copy Markdown

@sjhala-ccs: new pull request created: #110041

Details

In response to this:

/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

branch/enterprise-4.22 CNV Label for all CNV PRs jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants