NO-JIRA: Fix the "Enabling USB host passthrough" wrong procedure#110064
NO-JIRA: Fix the "Enabling USB host passthrough" wrong procedure#110064nunnatsa wants to merge 1 commit intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@nunnatsa: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/M
|
/cherrypick enterprise-4.22 |
|
@nunnatsa: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
🤖 Wed Apr 15 05:15:27 - Prow CI generated the docs preview: |
| product: "b100" | ||
| ---- | ||
| + | ||
| <1> `spec.permittedHostDevices` defines the host devices that have permission to be used in the cluster. |
There was a problem hiding this comment.
🤖 [error] AsciiDocDITA.CalloutList: Callouts are not supported in DITA.
The current Enabling USB host passthrough procedure is wrong in two ways. First, it uses the HyperConverged jsonpatch anntoation, which is not formally supported, and is should only be use as last resort, while the HyperConverged type contain the fields to implement the procedure in a supported way. In addition, the verification phase is also wrong, as it checks the HyperConverged instead of the KubeVirt CR. Signed-off-by: Nahshon Unna Tsameret <nunnatsa@redhat.com>
|
@nunnatsa: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
5 participants
While working on #109992, I noticed a very wrong procedure with the title of "Enabling USB host passthrough"
The current "Enabling USB host passthrough procedure" is wrong in three ways:
Version(s): v4.22, v4.21, v4.20, v4.19, v4.18