HIVE-3014: Revendor installer to v1.4.21-pre #2796

dlom · 2025-11-24T21:38:53Z

xref: HIVE-3014
xref: HIVE-3051
/assign @2uasimojo

Depends on openshift/machine-api-operator#1438

openshift-ci-robot · 2025-11-24T21:38:57Z

@dlom: This pull request references HIVE-3014 which is a valid jira issue.

Details

In response to this:

xref: HIVE-3014
/assign @2uasimojo

Depends on openshift/machine-api-operator#1438

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-11-24T21:39:02Z

@dlom: This pull request references HIVE-3014 which is a valid jira issue.

Details

In response to this:

xref: HIVE-3014
/assign @2uasimojo

Depends on openshift/machine-api-operator#1438

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

go.mod

codecov · 2025-11-24T23:51:49Z

Codecov Report

❌ Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.40%. Comparing base (c8e217d) to head (fe03307).
⚠️ Report is 10 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/controller/machinepool/azureactuator.go	83.33%	1 Missing and 1 partial ⚠️
...ller/clusterrelocate/clusterrelocate_controller.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2796   +/-   ##
=======================================
  Coverage   50.40%   50.40%           
=======================================
  Files         279      279           
  Lines       34194    34194           
=======================================
+ Hits        17235    17236    +1     
- Misses      15595    15597    +2     
+ Partials     1364     1361    -3

Files with missing lines	Coverage Δ
pkg/controller/machinepool/awsactuator.go	`77.86% <100.00%> (ø)`
pkg/controller/machinepool/nutanixactuator.go	`84.28% <100.00%> (+0.22%)`	⬆️
...ller/clusterrelocate/clusterrelocate_controller.go	`40.96% <0.00%> (ø)`
pkg/controller/machinepool/azureactuator.go	`73.17% <83.33%> (+2.77%)`	⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

2uasimojo · 2025-11-25T16:46:26Z

I'm going to hope that these validation budget checks were enabled by accident, temporarily.

/retest-required

2uasimojo · 2025-11-25T20:20:49Z

Ugh. @JoelSpeed what are we supposed to do about this?

Also, why is it complaining about an int64 field? Or does that just happen to be the point at which the whole budget got pushed over the edge?

dlom · 2025-11-29T01:29:23Z

Failing on the same The CustomResourceDefinition "clusterdeployments.hive.openshift.io" is invalid:

I see we're patching CRDs already to remove some things, should we do the same here? @2uasimojo

JoelSpeed · 2025-12-01T11:21:40Z

You need a max length on

hive/apis/hive/v1/clusterdeployment_types.go

Line 138 in 140ebad

Ingress []ClusterIngress `json:"ingress,omitempty"`

At the moment it's estimating the worst case as 3MiB over whatever the smallest object there is ({"name":"","domain":""} 23 chars) so approx 137k list entries. So every validation that exists in that list is 137k times larger than in o/api.

What's a sensible number of maximum ingresses you could retrofit to solve this without causing real world issues?

2uasimojo · 2025-12-01T21:54:50Z

/test e2e-openstack

dlom · 2025-12-01T23:17:29Z

/test e2e-openstack

dlom · 2025-12-02T00:49:30Z

/test e2e-azure

dlom · 2025-12-02T17:05:36Z

/retest

2uasimojo · 2025-12-02T20:27:34Z

/retest

red-hat-konflux · 2025-12-02T20:31:33Z

Caution

There are some errors in your PipelineRun template.

PipelineRun	Error
hive-mce-210-on-pull-request	`CEL expression evaluation error: expression "event == \"pull_request\"\n&& !body.pull_request.draft\n&& target_branch == \"master\"\n&& !files.all.all(x, x.matches('^docs/\|\\\\.md$\|^(?:.*/)?(?:\\\\.gitignore\|OWNERS\|PROJECT\|LICENSE)$'))\n" failed to evaluate: no such key: pull_request`
hive-mce-211-on-pull-request	`CEL expression evaluation error: expression "event == \"pull_request\"\n&& !body.pull_request.draft\n&& target_branch == \"master\"\n&& !files.all.all(x, x.matches('^docs/\|\\\\.md$\|^(?:.*/)?(?:\\\\.gitignore\|OWNERS\|PROJECT\|LICENSE)$'))\n" failed to evaluate: no such key: pull_request`
hive-mce-26-on-pull-request	`CEL expression evaluation error: expression "event == \"pull_request\"\n&& !body.pull_request.draft\n&& target_branch == \"master\"\n&& !files.all.all(x, x.matches('^docs/\|\\\\.md$\|^(?:.*/)?(?:\\\\.gitignore\|OWNERS\|PROJECT\|LICENSE)$'))\n" failed to evaluate: no such key: pull_request`
hive-mce-27-on-pull-request	`CEL expression evaluation error: expression "event == \"pull_request\"\n&& !body.pull_request.draft\n&& target_branch == \"master\"\n&& !files.all.all(x, x.matches('^docs/\|\\\\.md$\|^(?:.*/)?(?:\\\\.gitignore\|OWNERS\|PROJECT\|LICENSE)$'))\n" failed to evaluate: no such key: pull_request`
hive-mce-28-on-pull-request	`CEL expression evaluation error: expression "event == \"pull_request\"\n&& !body.pull_request.draft\n&& target_branch == \"master\"\n&& !files.all.all(x, x.matches('^docs/\|\\\\.md$\|^(?:.*/)?(?:\\\\.gitignore\|OWNERS\|PROJECT\|LICENSE)$'))\n" failed to evaluate: no such key: pull_request`
hive-mce-29-on-pull-request	`CEL expression evaluation error: expression "event == \"pull_request\"\n&& !body.pull_request.draft\n&& target_branch == \"master\"\n&& !files.all.all(x, x.matches('^docs/\|\\\\.md$\|^(?:.*/)?(?:\\\\.gitignore\|OWNERS\|PROJECT\|LICENSE)$'))\n" failed to evaluate: no such key: pull_request`
hive-on-pull-request	`CEL expression evaluation error: expression "event == \"pull_request\"\n&& !body.pull_request.draft\n&& target_branch == \"master\"\n&& !files.all.all(x, x.matches('^docs/\|\\\\.md$\|^(?:.*/)?(?:\\\\.gitignore\|OWNERS\|PROJECT\|LICENSE)$'))\n" failed to evaluate: no such key: pull_request`

dlom · 2025-12-02T22:59:54Z

/test e2e-openstack

dlom · 2025-12-03T01:24:27Z

/retest-required

2uasimojo · 2025-12-03T16:41:57Z

/retest-required

dlom · 2025-12-03T18:56:31Z

/test e2e-openstack

dlom · 2026-01-13T04:02:25Z

/unhold

2uasimojo

I'd like to understand what our previous support stance was on multi-zone pools, because it looks like we might have a gap now. If there's no regression, I'm happy to land this now and worry about that in a fup.

2uasimojo · 2026-01-13T15:08:04Z

pkg/controller/machinepool/azureactuator.go

 		},
 	}

+	if pool.Spec.Platform.Azure.ComputeSubnet != "" {


Looks like we may be inheriting some tech debt here to support multiple subnets? Do we have a card for this already?

2uasimojo · 2026-01-13T15:21:17Z

pkg/controller/machinepool/azureactuator.go

 		workerUserDataName,
 		capabilities,
-		useImageGallery,
+		[]string{},


Not sure I'm following the upstream code correctly, but it looks like, whereas the contents of this list are not used, the length of it needs to match that of pool.Spec.Azure.Zones for a multi-zone pool? (The list ends up here.) Can we run this by the installer team?

2uasimojo · 2026-01-13T15:28:24Z

hack/e2e-common.sh

 if [[ $0 == */e2e-pool-test.sh ]]; then
  # TODO: set this back to 148 when we figure out how to make the *test script*
  # timeout something other than 2h.
-  timeout_minutes=118
+  timeout_minutes=148
 else
-  timeout_minutes=118
+  timeout_minutes=148
 fi


Looks like we can collapse this now?

Perhaps the comment should indicate that this timeout needs to be shorter than the test timeout configured in the release repo? I think the purpose is to give our script a chance to clean up, since the generic overarching test timeout doesn't give us enough of a chance to do so?

…ge types

openshift-ci-robot · 2026-01-13T21:51:23Z

@dlom: This pull request references HIVE-3014 which is a valid jira issue.

Details

In response to this:

xref: HIVE-3014
xref: HIVE-3051
/assign @2uasimojo

Depends on openshift/machine-api-operator#1438

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-01-13T21:51:29Z

@dlom: This pull request references HIVE-3014 which is a valid jira issue.

Details

In response to this:

xref: HIVE-3014
xref: HIVE-3051
/assign @2uasimojo

Depends on openshift/machine-api-operator#1438

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

2uasimojo · 2026-01-13T22:17:53Z

/test hive-mce-29-on-pull-request hive-mce-210-on-pull-request

2uasimojo · 2026-01-13T22:18:54Z

/override "Red Hat Konflux"

🙄

openshift-ci · 2026-01-13T22:19:08Z

@2uasimojo: Overrode contexts on behalf of 2uasimojo: Red Hat Konflux

Details

In response to this:

/override "Red Hat Konflux"

🙄

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

2uasimojo

/lgtm

openshift-ci · 2026-01-13T22:20:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [2uasimojo,dlom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

2uasimojo · 2026-01-13T22:48:22Z

/test hive-mce-210-on-pull-request

2uasimojo · 2026-01-13T22:56:45Z

/hold for moar testing

dlom · 2026-01-14T00:36:11Z

/test e2e-openstack

dlom · 2026-01-14T00:36:23Z

/override "Red Hat Konflux"

openshift-ci · 2026-01-14T00:36:38Z

@dlom: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

Red Hat Konflux

Only the following failed contexts/checkruns were expected:

ci/prow/coverage
ci/prow/e2e
ci/prow/e2e-azure
ci/prow/e2e-gcp
ci/prow/e2e-openstack
ci/prow/e2e-pool
ci/prow/e2e-vsphere
ci/prow/images
ci/prow/periodic-images
ci/prow/security
ci/prow/unit
ci/prow/verify
pull-ci-openshift-hive-master-coverage
pull-ci-openshift-hive-master-e2e
pull-ci-openshift-hive-master-e2e-azure
pull-ci-openshift-hive-master-e2e-gcp
pull-ci-openshift-hive-master-e2e-openstack
pull-ci-openshift-hive-master-e2e-pool
pull-ci-openshift-hive-master-e2e-vsphere
pull-ci-openshift-hive-master-images
pull-ci-openshift-hive-master-periodic-images
pull-ci-openshift-hive-master-security
pull-ci-openshift-hive-master-unit
pull-ci-openshift-hive-master-verify
tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override "Red Hat Konflux"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

huangmingxia · 2026-01-14T03:49:03Z

/test e2e-azure

2uasimojo · 2026-01-14T13:29:39Z

/hold cancel

2uasimojo · 2026-01-14T15:22:04Z

/test security

openshift-ci-robot · 2026-01-14T15:32:35Z

/retest-required

Remaining retests: 0 against base HEAD 7dda648 and 2 for PR HEAD fe03307 in total

2uasimojo · 2026-01-14T17:42:07Z

/override ci/prow/security

Systemic. Addressing via HIVE-3053.

openshift-ci · 2026-01-14T17:42:26Z

@2uasimojo: Overrode contexts on behalf of 2uasimojo: ci/prow/security

Details

In response to this:

/override ci/prow/security

Systemic. Addressing via HIVE-3053.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-01-14T17:42:27Z

@dlom: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 24, 2025

openshift-ci bot assigned 2uasimojo Nov 24, 2025

dlom commented Nov 24, 2025

View reviewed changes

go.mod Outdated Show resolved Hide resolved

openshift-ci bot requested review from 2uasimojo and suhanime November 24, 2025 21:40

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2025

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2025

dlom force-pushed the HIVE-3014 branch from 7d48db1 to 6cc14a6 Compare November 24, 2025 23:42

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2025

2uasimojo mentioned this pull request Nov 26, 2025

HIVE-3007: hiveadmission: TLS config from APIServer #2800

Open

dlom force-pushed the HIVE-3014 branch from 6cc14a6 to 03f57bb Compare November 28, 2025 19:39

dlom force-pushed the HIVE-3014 branch 2 times, most recently from 54b7e89 to 6a927e3 Compare December 1, 2025 20:30

dlom force-pushed the HIVE-3014 branch from b7c457f to 7ac3348 Compare January 13, 2026 00:35

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2026

2uasimojo reviewed Jan 13, 2026

View reviewed changes

HIVE-3051: Add Plan field to Azure OSImage to support marketplace ima…

fe03307

…ge types

openshift deleted a comment from openshift-ci bot Jan 13, 2026

2uasimojo reviewed Jan 13, 2026

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2026

openshift deleted a comment from openshift-ci bot Jan 13, 2026

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2026

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2026

openshift-merge-bot bot merged commit 78f50cd into openshift:master Jan 14, 2026
27 of 28 checks passed

HIVE-3014: Revendor installer to v1.4.21-pre #2796

HIVE-3014: Revendor installer to v1.4.21-pre #2796

Uh oh!

Conversation

dlom commented Nov 24, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 24, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 24, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

2uasimojo commented Nov 25, 2025

Uh oh!

2uasimojo commented Nov 25, 2025

Uh oh!

dlom commented Nov 29, 2025

Uh oh!

JoelSpeed commented Dec 1, 2025

Uh oh!

2uasimojo commented Dec 1, 2025

Uh oh!

dlom commented Dec 1, 2025

Uh oh!

dlom commented Dec 2, 2025

Uh oh!

dlom commented Dec 2, 2025

Uh oh!

2uasimojo commented Dec 2, 2025

Uh oh!

red-hat-konflux bot commented Dec 2, 2025

Uh oh!

dlom commented Dec 2, 2025

Uh oh!

dlom commented Dec 3, 2025

Uh oh!

2uasimojo commented Dec 3, 2025

Uh oh!

dlom commented Dec 3, 2025

Uh oh!

dlom commented Jan 13, 2026

Uh oh!

2uasimojo left a comment

Choose a reason for hiding this comment

Uh oh!

2uasimojo Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

2uasimojo Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

2uasimojo Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Jan 13, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 13, 2026 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

2uasimojo commented Jan 13, 2026

Uh oh!

2uasimojo commented Jan 13, 2026

Uh oh!

openshift-ci bot commented Jan 13, 2026

Uh oh!

2uasimojo left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jan 13, 2026

Uh oh!

2uasimojo commented Jan 13, 2026

Uh oh!

2uasimojo commented Jan 13, 2026

dlom commented Nov 24, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 24, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 24, 2025 •

edited by openshift-ci bot

Loading

codecov bot commented Nov 24, 2025 •

edited

Loading

openshift-ci-robot commented Jan 13, 2026 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jan 13, 2026 •

edited by openshift-ci bot

Loading