HIVE-3007: hiveadmission: TLS config from APIServer #2800
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
jira/valid-reference
|
@2uasimojo: This pull request references HIVE-3007 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 2uasimojo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
This is currently in dependency hell.
We'll wait for #2796 and try again (library-go @release-4.20 to avoid k8s bump). |
Honor global TLS configuration by discovering TLS minimum version and cipher suites from the `APIServer cluster` object and adding their respective arguments to the hiveadmission Deployment. Assisted-By: The Claude (claude-sonnet-4-5@20250929) Claude helped me figure out minimal implementations for the Listers and Recorder I needed to invoke library-go's `ObserveTLSSecurityProfileToArguments()` function. (I feel like I shouldn't have had to create whole implementations to make this work. But maybe it's because this repo is using archaic mechanisms to interact with the KAS.)
2uasimojo
force-pushed
the
HIVE-3007/global-tls-config
branch
from
55f9929 to
00995b0
Compare
|
/hold |
openshift-ci
bot
added
do-not-merge/hold
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2800 +/- ##
==========================================
- Coverage 50.40% 50.29% -0.11%
==========================================
Files 279 280 +1
Lines 34194 34267 +73
==========================================
Hits 17236 17236
- Misses 15597 15670 +73
Partials 1361 1361
🚀 New features to boost your workflow:
|
|
@2uasimojo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Honor global TLS configuration by discovering TLS minimum version and cipher suites from the
APIServer clusterobject and adding their respective arguments to the hiveadmission Deployment.Assisted-By: The Claude (claude-sonnet-4-5@20250929)
Claude helped me figure out minimal implementations for the Listers and Recorder I needed to invoke library-go's
ObserveTLSSecurityProfileToArguments()function. (I feel like I shouldn't have had to create whole implementations to make this work. But maybe it's because this repo is using archaic mechanisms to interact with the KAS.)