Skip to content

OCPBUGS-81702: Handle pull-secret checkbox on OVE cluster details page #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Apr 7, 2026
+112 −9
Merged

OCPBUGS-81702: Handle pull-secret checkbox on OVE cluster details page #1881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
121 changes: 112 additions & 9 deletions agent/isobuilder/ui_driven_cluster_installation/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,14 @@ import (
"github.com/sirupsen/logrus"
)

// timestampedPath adds a timestamp to the filename
func timestampedPath(basePath, suffix string) string {
ext := filepath.Ext(basePath)
nameWithoutExt := strings.TrimSuffix(basePath, ext)
timestamp := time.Now().Format("20060102-150405")
return fmt.Sprintf("%s-%s-%s%s", nameWithoutExt, suffix, timestamp, ext)
}

var (
clusterName = os.Getenv("CLUSTER_NAME")
baseDomain = os.Getenv("BASE_DOMAIN")
Expand Down Expand Up @@ -147,7 +155,11 @@ func main() {
customManifestsHeading, _ := page.Timeout(2*time.Second).ElementR("h2", "Custom manifests")
if customManifestsHeading != nil {
logrus.Info("Custom manifests page detected (OCP 4.22+)")
err = saveFullPageScreenshot(page, filepath.Join(screenshotPath, fmt.Sprintf("%02d-custom-manifests.png", stepNum)))
err = saveFullPageScreenshot(page, timestampedPath(filepath.Join(screenshotPath, fmt.Sprintf("%02d-custom-manifests.png", stepNum)), "start"))
if err != nil {
log.Fatalf("failed custom manifests screenshot: %v", err)
}
err = saveFullPageScreenshot(page, timestampedPath(filepath.Join(screenshotPath, fmt.Sprintf("%02d-custom-manifests.png", stepNum)), "end"))
if err != nil {
log.Fatalf("failed custom manifests screenshot: %v", err)
}
Expand All @@ -173,15 +185,74 @@ func main() {
}
}
func clusterDetails(page *rod.Page, path string) error {
// Wait for the page to fully load before taking screenshot
page.MustElement("#form-input-name-field").MustWaitVisible()
err := saveFullPageScreenshot(page, timestampedPath(path, "start"))
if err != nil {
return err
}

page.MustElement("#form-input-name-field").MustInput(clusterName)
page.MustElement("#form-input-baseDnsDomain-field").MustInput(baseDomain)
page.MustElement("#form-input-pullSecret-field").MustInput(`{"auths":{"":{"auth":"dXNlcjpwYXNz"}}}`)

// Find the "Edit pull secret" checkbox if it exists
var pullSecretCheckbox *rod.Element

// Try finding by ID patterns first
pullSecretCheckbox, _ = page.Timeout(2 * time.Second).Element("input[type='checkbox'][id*='pullSecret']")

// Fallback: find via label text
if pullSecretCheckbox == nil {
label, _ := page.Timeout(2 * time.Second).ElementR("label", "Edit pull secret")
if label != nil {
forAttr, _ := label.Attribute("for")
if forAttr != nil {
pullSecretCheckbox, _ = page.Timeout(2 * time.Second).Element("#" + *forAttr)
}
}
}

if pullSecretCheckbox != nil {
// Verify checkbox state before clicking
checked, _ := pullSecretCheckbox.Property("checked")
wasUnchecked := !checked.Bool()

if wasUnchecked {
// Checkbox is unchecked, click it to reveal the field
logrus.Info("Found 'Edit pull secret' checkbox (unchecked), clicking to reveal field...")
pullSecretCheckbox.MustClick()
} else {
logrus.Info("Found 'Edit pull secret' checkbox (already checked), field should be visible")
}

// Wait for pull secret field to be visible
pullSecretField := page.MustElement("#form-input-pullSecret-field")
pullSecretField.MustWaitVisible()

// Take screenshot showing the revealed field (only if we clicked the checkbox)
if wasUnchecked {
err = saveFullPageScreenshot(page, timestampedPath(path, "after-checkbox"))
if err != nil {
return err
}
}

// Clear template content and enter pull secret
pullSecretField.MustSelectAllText()
pullSecretField.MustInput("")
time.Sleep(500 * time.Millisecond)

pullSecretField.MustInput(`{"auths":{"":{"auth":"dXNlcjpwYXNz"}}}`)
} else {
// Old UI: no checkbox, field already visible, enter pull secret directly
page.MustElement("#form-input-pullSecret-field").MustInput(`{"auths":{"":{"auth":"dXNlcjpwYXNz"}}}`)
}

// Allow UI enough time to complete the background API call to create the cluster
time.Sleep(10 * time.Second)
page.MustElement("button[name='next']").MustWaitEnabled()

err := saveFullPageScreenshot(page, path)
err = saveFullPageScreenshot(page, timestampedPath(path, "end"))
if err != nil {
return err
}
Expand Down Expand Up @@ -259,50 +330,77 @@ func patchInstallConfig(clustersURL string, featureSet string, featureGates stri
}

func virtualizationBundle(page *rod.Page, path string) error {
err := saveFullPageScreenshot(page, timestampedPath(path, "start"))
if err != nil {
return err
}

checkbox := page.MustElement("#bundle-virtualization")
checkbox.MustScrollIntoView()
checkbox.MustClick()
// Allow UI enough time to complete the background API call
time.Sleep(2 * time.Second)
page.MustElement("button[name='next']").MustWaitEnabled()
err := saveFullPageScreenshot(page, path)

err = saveFullPageScreenshot(page, timestampedPath(path, "end"))
if err != nil {
return err
}
return nil
}

func hostDiscovery(page *rod.Page, path string) error {
err := saveFullPageScreenshot(page, timestampedPath(path, "start"))
if err != nil {
return err
}

page.MustElement("button[name='next']").MustWaitEnabled()
err := saveFullPageScreenshot(page, path)

err = saveFullPageScreenshot(page, timestampedPath(path, "end"))
if err != nil {
return err
}
return nil
}

func verifyStorage(page *rod.Page, path string) error {
err := saveFullPageScreenshot(page, path)
err := saveFullPageScreenshot(page, timestampedPath(path, "start"))
if err != nil {
return err
}

err = saveFullPageScreenshot(page, timestampedPath(path, "end"))
if err != nil {
return err
}
return nil
}

func networkingDetails(page *rod.Page, path string) error {
err := saveFullPageScreenshot(page, timestampedPath(path, "start"))
if err != nil {
return err
}

page.MustElement("#form-input-apiVips-0-ip-field").MustInput(apiVips)
page.MustElement("#form-input-ingressVips-0-ip-field").MustInput(ingressVips)
page.MustElement("#form-input-sshPublicKey-field").MustInput(sshPublicKey)
page.MustElement(`button[name="next"]`).MustWaitEnabled()

err := saveFullPageScreenshot(page, path)
err = saveFullPageScreenshot(page, timestampedPath(path, "end"))
if err != nil {
return err
}
return nil
}

func downloadCredentials(page *rod.Page, client *resty.Client, path string) error {
err := saveFullPageScreenshot(page, timestampedPath(path, "start"))
if err != nil {
return err
}

clusterID, err := getClusterID(client, clustersURL)
if err != nil {
return err
Expand All @@ -324,17 +422,22 @@ func downloadCredentials(page *rod.Page, client *resty.Client, path string) erro

page.MustElementR("button", "Download credentials").MustWaitEnabled().MustClick()

err = saveFullPageScreenshot(page, path)
err = saveFullPageScreenshot(page, timestampedPath(path, "end"))
if err != nil {
return err
}
return nil
}

func review(page *rod.Page, path string) error {
err := saveFullPageScreenshot(page, timestampedPath(path, "start"))
if err != nil {
return err
}

installBtn := page.MustElementR("button", "Install cluster")

err := saveFullPageScreenshot(page, path)
err = saveFullPageScreenshot(page, timestampedPath(path, "end"))
if err != nil {
return err
}
Expand Down