Skip to content

OCPBUGS-81702: Handle pull-secret checkbox on OVE cluster details page#1881

Open
bfournie wants to merge 1 commit intoopenshift-metal3:masterfrom
bfournie:ui-ps-checkbox
Open

OCPBUGS-81702: Handle pull-secret checkbox on OVE cluster details page#1881
bfournie wants to merge 1 commit intoopenshift-metal3:masterfrom
bfournie:ui-ps-checkbox

Conversation

@bfournie
Copy link
Copy Markdown
Contributor

@bfournie bfournie commented Apr 3, 2026

The OVE UI cluster details page now has a checkbox in order to enter the pull secret. This adds support for it to the UI-driven installation.

In addition, in order to improve debugging on this page, and other pages, a screenshot is taken when entering the page and prior to leaving the page.

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bfournie for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bfournie
Copy link
Copy Markdown
Contributor Author

bfournie commented Apr 3, 2026

/cc @andfasano
/cc @rwsu

@openshift-ci openshift-ci bot requested review from andfasano and rwsu April 3, 2026 20:20
@bfournie
Copy link
Copy Markdown
Contributor Author

bfournie commented Apr 3, 2026

Confirmed that checkbox is now used and installation is successful

time="2026-04-03T21:06:10+02:00" level=info msg="Enter cluster details"
time="2026-04-03T21:06:11+02:00" level=info msg="Screenshot saved to/home/stack/dev-scripts-bfournie-latest/ocp/ostest/01-cluster-details-start-20260403-210611.png, with type of image/png"
time="2026-04-03T21:06:13+02:00" level=info msg="Found 'Edit pull secret' checkbox, clicking to reveal field..."
time="2026-04-03T21:06:15+02:00" level=info msg="Screenshot saved to/home/stack/dev-scripts-bfournie-latest/ocp/ostest/01-cluster-details-after-checkbox-20260403-210615.png, with type of image/png"
time="2026-04-03T21:06:26+02:00" level=info msg="Screenshot saved to/home/stack/dev-scripts-bfournie-latest/ocp/ostest/01-cluster-details-end-20260403-210626.png, with type of image/png"
time="2026-04-03T21:06:26+02:00" level=info msg="Waiting for operators page to load..."

The OVE UI cluster details page now has a checkbox in order to
enter the pull secret. This adds support for it to the UI-driven
installation.

In addition, in order to improve debugging on this page, and other
pages, a screenshot is taken when entering the page and prior to
leaving the page.
// Checkbox is unchecked, click it to reveal the field
logrus.Info("Found 'Edit pull secret' checkbox (unchecked), clicking to reveal field...")
pullSecretCheckbox.MustClick()
time.Sleep(2 * time.Second)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sleeps seems extraneous. If we are waiting for the pull secret field to be visible doesn't pullSecretField.MustWaitVisible() in line 234 achieve that?

if pullSecretCheckbox != nil {
// Verify checkbox state before clicking
checked, _ := pullSecretCheckbox.Property("checked")
if checked.Bool() == false {
Copy link
Copy Markdown
Contributor

@rwsu rwsu Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
if checked.Bool() == false {
!checked.Bool()

@rwsu
Copy link
Copy Markdown
Contributor

rwsu commented Apr 5, 2026

/retest-required

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 5, 2026

@bfournie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ovn-arbiter a68e293 link false /test e2e-metal-ovn-arbiter
ci/prow/e2e-agent-compact-ipv4 a68e293 link true /test e2e-agent-compact-ipv4

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants