OCPBUGS-81702: Handle pull-secret checkbox on OVE cluster details page#1881
OCPBUGS-81702: Handle pull-secret checkbox on OVE cluster details page#1881bfournie wants to merge 1 commit intoopenshift-metal3:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/cc @andfasano |
|
Confirmed that checkbox is now used and installation is successful |
The OVE UI cluster details page now has a checkbox in order to enter the pull secret. This adds support for it to the UI-driven installation. In addition, in order to improve debugging on this page, and other pages, a screenshot is taken when entering the page and prior to leaving the page.
| // Checkbox is unchecked, click it to reveal the field | ||
| logrus.Info("Found 'Edit pull secret' checkbox (unchecked), clicking to reveal field...") | ||
| pullSecretCheckbox.MustClick() | ||
| time.Sleep(2 * time.Second) |
There was a problem hiding this comment.
This sleeps seems extraneous. If we are waiting for the pull secret field to be visible doesn't pullSecretField.MustWaitVisible() in line 234 achieve that?
| if pullSecretCheckbox != nil { | ||
| // Verify checkbox state before clicking | ||
| checked, _ := pullSecretCheckbox.Property("checked") | ||
| if checked.Bool() == false { |
There was a problem hiding this comment.
nit
| if checked.Bool() == false { | |
| !checked.Bool() |
|
/retest-required |
|
@bfournie: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The OVE UI cluster details page now has a checkbox in order to enter the pull secret. This adds support for it to the UI-driven installation.
In addition, in order to improve debugging on this page, and other pages, a screenshot is taken when entering the page and prior to leaving the page.