fix: notification sound + TryParseArgv refactor (closes #91, #92, #71)#125
Merged
shanselman merged 2 commits intomasterfrom Mar 31, 2026
Merged
Conversation
…#91) - Extract TryParseArgv(JsonElement) to consolidate duplicated argv parsing in HandleRunPrepare and HandleRunAsync (~20 lines each → one 20-line helper) - Fix operator precedence in HandleExecApprovalsSet: add parentheses to make (True || False) grouping explicit (was safe by coincidence but misleading) - Add 5 new tests for argv parsing: array, string, empty, missing, multi-arg Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add ShowToast() helper that checks _settings.NotificationSound and configures audio accordingly (None=silent, Subtle=IM sound, Default= system default). Replace all 14 direct .Show() calls with ShowToast(). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Apr 1, 2026
[Repo Assist] refactor: extract TryParseArgv helper in SystemCapability, fix operator precedence
#96
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two Repo Assist fixes reviewed and implemented fresh against current master.
1. TryParseArgv extraction + operator precedence (closes #91)
2. NotificationSound applied to all toasts (closes #92, closes #71)
Reviewed by Sonnet 4.5 — no issues found.
All 601 tests pass (508 shared + 93 tray).
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com