[Repo Assist] fix: apply NotificationSound setting to all toast notifications#95
Closed
github-actions[bot] wants to merge 1 commit intomasterfrom
Conversation
The NotificationSound setting (Default / None / Subtle) was saved and restored correctly by SettingsWindow but never applied when building toast notifications. Every toast always fired with the system default sound regardless of user preference. Adds a ShowToast(ToastContentBuilder) helper that applies the audio preference before calling .Show(), and updates all 14 toast call sites in App.xaml.cs to use it: - 'None' → silent toast (AddAudio(silent: true)) - 'Subtle' → ms-winsoundevent:Notification.IM - 'Default' → system default (no-op, existing behaviour) Closes #71 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
36 tasks
github-actions bot
added a commit
that referenced
this pull request
Mar 31, 2026
When an agent invokes system.notify with sound=false, the PlaySound field in SystemNotifyArgs was correctly populated by SystemCapability but then silently ignored in OnNodeNotificationRequested. The toast was always shown with sound regardless of the per-notification flag. Fix: check args.PlaySound before showing the toast and add a silent audio element when the agent has explicitly requested no sound. This is orthogonal to the user-level NotificationSound preference (addressed in PR #95): PlaySound=false suppresses sound for that specific notification only, regardless of the global sound setting. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
|
Superseded by PR #125 which implemented the same NotificationSound fix against current code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated contribution from Repo Assist.
Root Cause
The
NotificationSoundsetting in tray settings was saved and restored correctly bySettingsWindowbut was never applied when building toast notifications. Every toast always fired with the system default sound regardless of user preference — all 14 direct.Show()call sites inApp.xaml.csbypassed the setting entirely.Fix
Introduces a
ShowToast(ToastContentBuilder)helper inApp.xaml.csthat applies the audio preference before calling.Show():None→ silent toast (AddAudio(silent: true))Subtle→ms-winsoundevent:Notification.IMDefault→ system default (no-op, existing behaviour)All 14 direct
.Show()call sites inApp.xaml.csare routed throughShowToast(...)instead.Test Status
Tests could not be run in the Linux CI environment (project targets Windows). The logic is straightforward: one helper method added, all call sites updated mechanically.
Closes #71
Closes #92