qcatch: Add doublet detection test#10126
Merged
DongzeHE merged 3 commits intonf-core:masterfrom Feb 26, 2026
Merged
Conversation
3 tasks
Contributor
Author
|
@mashehu any comments? |
an-altosian
force-pushed
the
qcatch-doublet-test
branch
from
9ae46fe to
f52c385
Compare
mashehu
requested changes
Feb 25, 2026
- Add test_qcatch - remove_doublets test exercising the --remove_doublets code path. Uses file size > 0 assertions for non-deterministic outputs and snapshots versions.yml. - Update qcatch to 0.2.11 (bundles scikit-image, removes need for separate scikit-image pip dependency) - Update container images to 0.2.11 - Use https link for Singularity container Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
an-altosian
force-pushed
the
qcatch-doublet-test
branch
from
f52c385 to
37e736b
Compare
mashehu
approved these changes
Feb 26, 2026
an-altosian
added a commit
to an-altosian/scrnaseq
that referenced
this pull request
Feb 26, 2026
- Bump qcatch to 0.2.11 (scikit-image now bundled in package) - New container with python 3.14.3 - Add doublet detection test (remove_doublets) with dedicated config - Add versions yaml assertion to main test - Update snapshots and modules.json SHA Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address nf-test concerns for the qcatch module in #10125.
Summary
test_qcatch - remove_doubletstest that exercises the--remove_doubletscode path requiring scikit-imageversions.ymlfor deterministic validationAddresses review feedback from @mashehu on #10125.
Test plan
🤖 Generated with Claude Code