qcatch: Add scikit-image dependency and enable doublet detection tests#10125
Merged
DongzeHE merged 4 commits intonf-core:masterfrom Feb 21, 2026
Merged
qcatch: Add scikit-image dependency and enable doublet detection tests#10125DongzeHE merged 4 commits intonf-core:masterfrom
DongzeHE merged 4 commits intonf-core:masterfrom
Conversation
scikit-image is required by scanpy.pp.scrublet() for doublet detection when no explicit threshold is provided. Updated container images to include scikit-image==0.26.0 and enabled --remove_doublets --visualize_doublets in the test config to exercise this code path. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Split tests into: (1) base test without doublet args using deterministic md5 snapshots, (2) doublet detection test with --remove_doublets --visualize_doublets that validates output file existence. Both tests exercise the scikit-image dependency. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mashehu
reviewed
Feb 21, 2026
Doublet detection (scrublet) is deterministic with default random_state=0, so use one test with --remove_doublets --visualize_doublets and md5 snapshots for all outputs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Scrublet doublet detection produces different numerical results across CPU architectures (BLAS/LAPACK differences), causing h5ad md5 mismatches between local and CI. Remove --remove_doublets --visualize_doublets from test config to keep deterministic md5 snapshots. scikit-image dependency is still included in the container for users who need doublet detection. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
an-altosian
added a commit
to an-altosian/scrnaseq
that referenced
this pull request
Feb 21, 2026
…itespace Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
mashehu
reviewed
Feb 22, 2026
Contributor
mashehu
left a comment
There was a problem hiding this comment.
Why did you remove the tests for the functionality in the last commit? If the content is unstable we still have ways to test the functionality https://nf-co.re/docs/contributing/nf-test/assertions#nf-core-guidelines-for-assertions please add the test back to ensure that this functionality will not be broken again in the future
Contributor
Author
|
@mashehu Good point, thanks for the link! Added the doublet detection test back (
The base test without doublet args keeps full md5 snapshots for h5ad and CSV. PR #10126 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scikit-image==0.26.0as a pip dependency inenvironment.yml— required byscanpy.pp.scrublet()for doublet detection when no explicit threshold is providedpip_qcatch_scikit-imagevariants)--remove_doublets --visualize_doubletsflags in test config to exercise the Scrublet doublet detection code pathTest plan
🤖 Generated with Claude Code