Skip to content

Integrate multiqcsav into bcl_demultiplex subworkflow#10117

Draft
delfiterradas wants to merge 5 commits intonf-core:masterfrom
delfiterradas:multiqc_sav
Draft

Integrate multiqcsav into bcl_demultiplex subworkflow#10117
delfiterradas wants to merge 5 commits intonf-core:masterfrom
delfiterradas:multiqc_sav

Conversation

@delfiterradas
Copy link
Contributor

Based on #9883
Closes nf-core/demultiplex#360

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@delfiterradas delfiterradas self-assigned this Feb 19, 2026
@delfiterradas
Copy link
Contributor Author

Right now multiqcsav works with bclconvert, but it is not working when using bcl2fastq

@delfiterradas
Copy link
Contributor Author

delfiterradas commented Feb 26, 2026

Hi @matthdsm, I am trying to include the multiqcsav module in the bcl_demultiplex subworkflow based on the PR you had started. When using bclconvert, mutiqcsav runs successfully. However, when using bcl2fastq I get an error saying that I need to provide the RunParameters.xml file (which is not created by neither of the modules but seems still seems to work for bclconvert). Do you know if this is expected to be happening?

@matthdsm
Copy link
Contributor

Hi @delfiterradas,

You can just feed all of the xml files from the run into multiqc_sav, that should fix your issue

@matthdsm
Copy link
Contributor

I just checked and the bcl2fastq doesn't output any xml files, so you're going to have to patch that module first

@matthdsm matthdsm mentioned this pull request Feb 26, 2026
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add MultiQC SAV Plugin to demux pipeline

2 participants