Skip to content

add xml output to bcl2fastq#10278

Merged
matthdsm merged 1 commit intomasterfrom
bcl2fastq/xml
Feb 26, 2026
Merged

add xml output to bcl2fastq#10278
matthdsm merged 1 commit intomasterfrom
bcl2fastq/xml

Conversation

@matthdsm
Copy link
Contributor

Outputs still seem to miss the RunParameters.xml , but that's because it's not in the test dataset.

cc @delfiterradas,
xref #10117

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@delfiterradas
Copy link
Contributor

Thank you for this @matthdsm!
I have tried the multiqcsav module with these changes but it still doesn't work... However, in the demultiplex pipeline it does, so it might be related to the test dataset :)

@matthdsm matthdsm added this pull request to the merge queue Feb 26, 2026
Merged via the queue into master with commit 5409e11 Feb 26, 2026
28 checks passed
@matthdsm matthdsm deleted the bcl2fastq/xml branch February 26, 2026 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants