Breaking: simplify within() to return unsorted results only #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove within() sorted variant, keep only unsorted results - Eliminate code duplication between within* methods - Update all tests to expect unsorted order - Simplify test naming and remove duplicates - Clean up API to reduce complexity while maintaining functionality This is a breaking change as within() no longer returns sorted results. Users who need sorted results should sort the output themselves.
mrhooray
force-pushed
the
simplify-within-unsorted-only
branch
from
4072960 to
ff00a2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Breaking Changes
Rationale
This eliminates the confusing sorted/unsorted duplication in the API while providing a cleaner, more Rust-idiomatic interface where users can sort results as needed.