Refactor: consolidate within* methods to eliminate code duplication #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract common logic into within_impl() and within_evaluated_heap() helpers - Reduce code duplication from 3 nearly identical methods to shared implementation - Maintain identical public API behavior while reducing maintenance burden - All existing tests pass without modification
mrhooray
force-pushed
the
refactor-within-methods
branch
from
69502f8 to
599fbc6
Compare
Owner
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This refactors the three within* methods (within, within_unsorted, within_count) which had significant code duplication in their validation and heap evaluation logic.