Skip to content

Conversation

@kaylee0307
Copy link
Contributor

@kaylee0307 kaylee0307 commented Apr 25, 2025

New content

Resolves #93

Checklist

  • New pages are added to the table of contents.
  • Everything displays correctly in the web-generated preview.
  • Appropriate attribution has been given to source materials.
  • My name is included alphabetically in credits.md.

@kaylee0307 kaylee0307 requested a review from mphoward April 25, 2025 21:24
@github-actions
Copy link

github-actions bot commented Apr 25, 2025

PR Preview Action v1.6.1
Preview removed because the pull request was closed.
2025-05-09 16:51 UTC

@mphoward mphoward requested review from mzbush and removed request for mphoward May 2, 2025 21:44
@mphoward mphoward changed the title Update separable.md Separation of variables skill builders May 2, 2025
Copy link
Contributor

@mzbush mzbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This skill builder has done a pretty good job translating the notes. There are three main changes that need to happen before the pull request can be merged.

  1. All of these changes should be moved down to the bottom of the page after the examples.
  2. The problems should use the {solution} directive so that the viewer can click to see the solution. I would recommend looking at the skill builder problems in calculus/series-expansion.md to get a better idea of how to use the {solution} directive.
  3. There should be some words to help explain the process of solving these equations.

I've added some suggested changes in problem a to improve the presentation of the problem and make it more in line with how the skill builder problems are expected to look. These sorts of changes should be applied to b and c as well.

Note that here, we are being careful to denote the redefinition of the
integration constant ($c = e^{c_0}$). This detail may be glossed over at times.

Solve the following:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Solve the following:
## Skill builder problems
Solve the following:

This section needs a heading


(a)

$$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$$

$$ is used to wrap equations that are on the same line as normal text. It is not needed here.

Comment on lines 30 to 38
\begin{alignat*}{3}
y'+(x+2)y^2 = 0 ; \quad y(1) = 1 \\
\frac{dy}{dx} = -(x+2)y^2 \\
\int\frac{dy}{y^2} = \int-(x+2)dx \\
-\frac{1}{y} = -\left(\frac{x^2}{2} + 2x\right) + C \\
y(1) = -1 = -\left(\frac{1}{2} + 2 \right) + C & \quad \to & \quad C = \frac{3}{2} \\
\to \quad y = \frac{2}{x^2+4x-3}
\end{alignat*}
$$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
\begin{alignat*}{3}
y'+(x+2)y^2 = 0 ; \quad y(1) = 1 \\
\frac{dy}{dx} = -(x+2)y^2 \\
\int\frac{dy}{y^2} = \int-(x+2)dx \\
-\frac{1}{y} = -\left(\frac{x^2}{2} + 2x\right) + C \\
y(1) = -1 = -\left(\frac{1}{2} + 2 \right) + C & \quad \to & \quad C = \frac{3}{2} \\
\to \quad y = \frac{2}{x^2+4x-3}
\end{alignat*}
$$
```{solution}
\begin{align}
\frac{dy}{dx} &= -(x+2)y^2 \\
\int\frac{dy}{y^2} &= \int-(x+2)dx \\
-\frac{1}{y} &= -\left(\frac{x^2}{2} + 2x\right) + C \\
\end{align}
\begin{equation}
y(1) = -1 = -\left(\frac{1}{2} + 2 \right) + C \quad \to \quad C = \frac{3}{2}
\end{equation}
\begin{equation}
\to \quad y = \frac{2}{x^2+4x-3}
\end{equation}
```

Solving the problem should all go inside a {solution} directive like other skill builder problems. This solution could also use some words to explain what is happening and what each group of expressions is accomplishing in order to get to the solution. In this instance, I have separated the integration, solving for the constant C, and the final answer into groups. There should be some text between these different groups.

@mphoward
Copy link
Contributor

mphoward commented May 7, 2025

@kaylee0307 please make sure to finalize this and request a review from me ASAP to get credit for it!

@kaylee0307 kaylee0307 requested a review from mzbush May 9, 2025 00:11
Copy link
Contributor

@mzbush mzbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request looks really so far. I have some suggestions to fix up a few minor things, and then once all of them are addressed I think it will be ready for merging.

Comment on lines 265 to 266
\begin{equation}
y = \sqrt{ln(x^2-2x+e}
\end{equation}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a ± here so it's consistent with problem b? Then after stating to choose the positive, the final equation would be restated without the ±.

Copy link
Contributor

@mphoward mphoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I applied Michaela's suggestions and reformatted your code.

@mphoward mphoward merged commit 939291f into main May 9, 2025
2 checks passed
@mphoward mphoward deleted the issue-93-1 branch May 9, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Separation of variables skill builders

4 participants