Skip to content

Fix mojo_library taking dependencies that require file path expansion #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jackos wants to merge 1 commit into from
Closed

Fix mojo_library taking dependencies that require file path expansion #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions mojo/mojo_library.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,10 @@ def _mojo_library_implementation(ctx):
},
use_default_shell_env = True,
toolchain = "//:toolchain_type",
execution_requirements = {
"supports-path-mapping": "1",
},
)

transitive_runfiles = []
for target in ctx.attr.data:
for target in ctx.attr.data + ctx.attr.deps:
Copy link
Contributor

@keith keith Jul 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the case where this is needed at runtime later?

transitive_runfiles.append(target[DefaultInfo].default_runfiles)

return [
Expand Down