Fix mojo_library taking dependencies that require file path expansion#39
Closed
jackos wants to merge 1 commit intomodular:mainfrom
Closed
Fix mojo_library taking dependencies that require file path expansion#39jackos wants to merge 1 commit intomodular:mainfrom
mojo_library taking dependencies that require file path expansion#39jackos wants to merge 1 commit intomodular:mainfrom
Conversation
Previously the `mojo package` command was unable to find bitcode libraries that were specified in `additional_compiler_inputs`, this exposes the file to the correct path.
keith
reviewed
Jul 28, 2025
|
|
||
| transitive_runfiles = [] | ||
| for target in ctx.attr.data: | ||
| for target in ctx.attr.data + ctx.attr.deps: |
Contributor
There was a problem hiding this comment.
what's the case where this is needed at runtime later?
Contributor
Author
|
Closing, was using Bazel incorrectly, using filegroup without a genrule works fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the
mojo packagecommand was unable to find bitcodelibraries that were specified in
additional_compiler_inputs, thisexposes the file to the correct path.