Skip to content

Added policy for 8480 to support Cinematic Framing #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WSEAutomationTests wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added policy for 8480 to support Cinematic Framing #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion E2E/Library/Policy.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,16 @@ function Check8380Policy
{
return $true
}
}
}
Copy link

Copilot AI Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Check8480Policy function is missing documentation comments. All other functions in this file have documentation blocks following the same format that describe the function's purpose, input parameters, and return type. Add a documentation comment block above this function following the same pattern used by CheckVoiceFocusPolicy, CheckWSEV2Policy, and Check8380Policy.

Suggested change
}
}
<#
DESCRIPTION:
This function checks whether the 8480 policy is supported on the system.
It verifies the existence of the 'libQnnHtpV81Skel.so' library file in the
DriverStore directory, which is required for this policy.
INPUT PARAMETERS:
- None
RETURN TYPE:
- [bool] (Returns $true if the 8480 policy is supported, otherwise returns $false.)
#>

Copilot uses AI. Check for mistakes.
function Check8480Policy
{
$libQnnHtpV81Skel = "C:\Windows\System32\DriverStore\FileRepository\microsofteffectpack_extension.inf*\libQnnHtpV81Skel.so"
if(Test-path -Path $libQnnHtpV81Skel)
{
return $true
}
else
{
return $false
Comment on lines +63 to +69
Copy link

Copilot AI Dec 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic pattern in this function is inconsistent with the similar Check8380Policy function. Check8380Policy uses a negative condition check (if NOT exists, return false, else return true), while this function uses a positive condition check (if exists, return true, else return false). Although both are functionally correct, maintaining a consistent pattern improves code maintainability. Consider using the same pattern as Check8380Policy to maintain consistency.

Suggested change
if(Test-path -Path $libQnnHtpV81Skel)
{
return $true
}
else
{
return $false
if(!(Test-path -Path $libQnnHtpV81Skel))
{
return $false
}
else
{
return $true

Copilot uses AI. Check for mistakes.
}
}