Added policy for 8480 to support Cinematic Framing #83
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for the Cinematic Framing feature on 8480 devices by introducing a new policy checking function. The implementation follows a similar pattern to existing device-specific policy checks in the codebase.
- Adds
Check8480Policyfunction to verify the presence of the requiredlibQnnHtpV81Skel.solibrary file - Implements device-specific policy validation for 8480 hardware supporting Cinematic Framing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return $true | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
The Check8480Policy function is missing documentation comments. All other functions in this file have documentation blocks following the same format that describe the function's purpose, input parameters, and return type. Add a documentation comment block above this function following the same pattern used by CheckVoiceFocusPolicy, CheckWSEV2Policy, and Check8380Policy.
| } | |
| } | |
| <# | |
| DESCRIPTION: | |
| This function checks whether the 8480 policy is supported on the system. | |
| It verifies the existence of the 'libQnnHtpV81Skel.so' library file in the | |
| DriverStore directory, which is required for this policy. | |
| INPUT PARAMETERS: | |
| - None | |
| RETURN TYPE: | |
| - [bool] (Returns $true if the 8480 policy is supported, otherwise returns $false.) | |
| #> |
| if(Test-path -Path $libQnnHtpV81Skel) | ||
| { | ||
| return $true | ||
| } | ||
| else | ||
| { | ||
| return $false |
There was a problem hiding this comment.
The logic pattern in this function is inconsistent with the similar Check8380Policy function. Check8380Policy uses a negative condition check (if NOT exists, return false, else return true), while this function uses a positive condition check (if exists, return true, else return false). Although both are functionally correct, maintaining a consistent pattern improves code maintainability. Consider using the same pattern as Check8380Policy to maintain consistency.
| if(Test-path -Path $libQnnHtpV81Skel) | |
| { | |
| return $true | |
| } | |
| else | |
| { | |
| return $false | |
| if(!(Test-path -Path $libQnnHtpV81Skel)) | |
| { | |
| return $false | |
| } | |
| else | |
| { | |
| return $true |
What changed?
Added policy specific to 8480 to support Cinematic Framing.
Why changed?
Cinematic Framing is a newly added feature on 8480 devices.
How did you test the change?
Tested on 8480 devices
Related Issues (if any):