Bluetooth permissions; A+B reset #682
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hacky image just like triple tap, they need redoing. This one looks terrible on a non-black background so use that for now.
|
Preview build will be at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only deals with Bluetooth permissions in the data connection flow.
They also apply to the download flow (especially if you skip past connecting, but all the time in principle) but I want to refactor in a separate PR to enable better sharing between the flows before implementing it there.
I've also added in the missing A+B reset dialog.
I regenerated all the translated strings via
find lang -type f -not -name ui.en.json | while read n; do git checkout main -- $n; done && npm run i18n:compileas they were a mess and no actual translation has happened on the apps branch.Bugs in this PR may actually be bugs in microbit-foundation/microbit-connection#73 which I have released in the interest of forward progress but should be reviewed alongside this.
Note this PR targets the apps branch.