Improve dialogs on mobile #684
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're far from great but this makes it nicer to work through the connection flow on a phone. No plans to fix the bigger issues with the recording/test model grids for now though. This needs a corresponding private theme change.
|
Preview build will be at |
| ? predictionResult?.detected?.ID === value.ID | ||
| : undefined; | ||
| // Avoid autofocus on mobile as it triggers the keyboard | ||
| const allowAutoFocus = useBreakpointValue({ base: false, md: true }); |
There was a problem hiding this comment.
This is extremely annoying!
| /** | ||
| * Responsive layout for modal footer content. | ||
| * On desktop: left content and buttons side by side. | ||
| * On mobile: left content stacked above buttons. |
There was a problem hiding this comment.
I don't love how this looks but it's better than overflowing the width. Suggestions welcome but this is mainly for testing anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're far from great but this makes it nicer to work through the connection flow on a phone. No plans to fix the bigger issues with the recording/test model grids for now though.
This needs a corresponding private theme change.
Draft with temporary base branch until #682 is merged.