-
Notifications
You must be signed in to change notification settings - Fork 247
Release 1.13.0 #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.13.0 #418
Changes from all commits
c72d249
c282562
d3c23e4
a8dfee2
9f1b931
f1ace85
b5809f9
de43d4f
955731d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -81,17 +81,14 @@ if [ -n "$(git status --porcelain)" ]; then | |||||
| exit 1 | ||||||
| fi | ||||||
|
|
||||||
| old_version=$( | ||||||
| perl -MFile::Slurp=read_file <<EOF | ||||||
| use v5.16; | ||||||
| my \$conf = read_file(q{configure.ac}); | ||||||
| \$conf =~ /AC_INIT.+\[(\d+\.\d+\.\d+)\]/; | ||||||
| say \$1; | ||||||
| EOF | ||||||
| ) | ||||||
| ac_init=$(grep AC_INIT configure.ac) | ||||||
| if [[ ! $ac_init =~ \[([0-9]+\.[0-9]+\.[0-9]+)\] ]]; then | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The regex for extracting the old version from
Suggested change
|
||||||
| echo "Could not find version in configure.ac!" | ||||||
| exit 1 | ||||||
| fi | ||||||
| old_version="${BASH_REMATCH[1]}" | ||||||
|
|
||||||
| perl -MFile::Slurp=edit_file -e \ | ||||||
| "edit_file { s/\Q$old_version/$version/g } \$_ for qw( configure.ac include/maxminddb.h CMakeLists.txt )" | ||||||
| perl -pi -e "s/\Q$old_version/$version/g" configure.ac include/maxminddb.h CMakeLists.txt | ||||||
|
|
||||||
| if [ -n "$(git status --porcelain)" ]; then | ||||||
| git diff | ||||||
|
|
||||||
| +9 −0 | .precious.toml | |
| +190 −194 | MaxMind-DB-spec.md | |
| +25 −3 | README.md | |
| +9 −6 | bad-data/README.md | |
| +66 −3 | cmd/write-test-data/main.go | |
| +12 −4 | pkg/writer/baddata.go | |
| +12 −12 | pkg/writer/rawmmdb.go | |
| +10 −7 | test-data/README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change removes the check that ensures the release date in
Changes.mdis today. This was present in the previous Perl implementation and is a useful safeguard. Additionally, the version parsing regex has a few issues: it doesn't handle pre-release versions, and it uses.which matches any character instead of a literal dot (\.). Usinghead -n 1is also more direct thanhead -n 3. I suggest restoring the date check and using a more robust and correct regex for consistency and safety.