Conversation
oschwald
commented
Feb 24, 2026
oschwald
commented
- Set release date and bump copyright year
- Remove File::Slurp dependency from release scripts
- Bumped version to 1.13.0
Replace File::Slurp-based version extraction with bash regex (grep + BASH_REMATCH) in release.sh and ppa-release.sh. Keep perl -pi -e for portable in-place substitution. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Summary of ChangesHello @oschwald, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request prepares the repository for the 1.13.0 release. It includes updates to the project version across various build and configuration files, advances the copyright year to 2026, and refactors release scripts to remove a Perl dependency, streamlining the release process. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request prepares for the 1.13.0 release by updating version numbers, copyright years, and the changelog. The release scripts have also been updated to remove a dependency on the Perl File::Slurp module, replacing it with standard shell commands. My review focuses on ensuring the new shell script implementations are robust and retain the functionality of the code they replace.
| changelog_header=$(head -n 3 Changes.md) | ||
| if [[ ! $changelog_header =~ ^##\ ([0-9]+\.[0-9]+\.[0-9]+)\ -\ ([0-9]{4}-[0-9]{2}-[0-9]{2}) ]]; then | ||
| echo "Could not find version in Changes.md!" | ||
| exit 1 | ||
| fi | ||
| VERSION="${BASH_REMATCH[1]}" |
There was a problem hiding this comment.
This change removes the check that ensures the release date in Changes.md is today. This was present in the previous Perl implementation and is a useful safeguard. Additionally, the version parsing regex has a few issues: it doesn't handle pre-release versions, and it uses . which matches any character instead of a literal dot (\.). Using head -n 1 is also more direct than head -n 3. I suggest restoring the date check and using a more robust and correct regex for consistency and safety.
| changelog_header=$(head -n 3 Changes.md) | |
| if [[ ! $changelog_header =~ ^##\ ([0-9]+\.[0-9]+\.[0-9]+)\ -\ ([0-9]{4}-[0-9]{2}-[0-9]{2}) ]]; then | |
| echo "Could not find version in Changes.md!" | |
| exit 1 | |
| fi | |
| VERSION="${BASH_REMATCH[1]}" | |
| changelog_header=$(head -n 1 Changes.md) | |
| if [[ ! $changelog_header =~ ^##\ ([0-9]+\\.[0-9]+\\.[0-9]+(?:-[a-zA-Z0-9.-]*)?)\ -\ ([0-9]{4}-[0-9]{2}-[0-9]{2}) ]]; then | |
| echo "Could not find version and date in Changes.md header!" | |
| exit 1 | |
| fi | |
| VERSION="${BASH_REMATCH[1]}" | |
| DATE="${BASH_REMATCH[2]}" | |
| if [[ "$DATE" != "$(date +"%Y-%m-%d")" ]]; then | |
| echo "Release date ($DATE) in Changes.md is not today!" | |
| exit 1 | |
| fi |
| EOF | ||
| ) | ||
| ac_init=$(grep AC_INIT configure.ac) | ||
| if [[ ! $ac_init =~ \[([0-9]+\.[0-9]+\.[0-9]+)\] ]]; then |
There was a problem hiding this comment.
The regex for extracting the old version from configure.ac has a couple of issues: it doesn't account for pre-release tags (e.g., 1.13.0-alpha.1), and it uses . which matches any character instead of a literal dot (\.). To make the script more robust and consistent with how the new version is parsed from Changes.md, consider updating the regex.
| if [[ ! $ac_init =~ \[([0-9]+\.[0-9]+\.[0-9]+)\] ]]; then | |
| if [[ ! $ac_init =~ \["([0-9]+\\.[0-9]+\\.[0-9]+(?:-[a-zA-Z0-9.-]*)?)"\] ]]; then |
The submodule was pointing to commit 29cab1f on a feature branch that has since been squash-merged and deleted, making it unreachable from any remote ref. This caused git-buildpackage to fail when creating the orig tarball since a fresh clone cannot fetch that commit. Point to current main (327e23a) which includes the equivalent squash-merged content. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 participant
