Skip to content

Nest with group_by: repeated-record fix#2090

Merged
mtoy-googly-moogly merged 24 commits intomainfrom
nest-grouped-repeated-record
Mar 31, 2025
Merged

Nest with group_by: repeated-record fix#2090
mtoy-googly-moogly merged 24 commits intomainfrom
nest-grouped-repeated-record

Conversation

@mtoy-googly-moogly
Copy link
Collaborator

@mtoy-googly-moogly mtoy-googly-moogly commented Jan 11, 2025

Attempting to fix #2065

This was a few pieces of work.

  • Adding a test for this.
  • Further re-factor of malloy_types for correctness in face of compound types
  • Re-enable some ancient code for grouping by nested values
  • Fixing the many dialects where that was broken because it was never tested.

@mtoy-googly-moogly mtoy-googly-moogly self-assigned this Jan 11, 2025
@mtoy-googly-moogly mtoy-googly-moogly merged commit 7439b94 into main Mar 31, 2025
15 checks passed
@mtoy-googly-moogly mtoy-googly-moogly deleted the nest-grouped-repeated-record branch March 31, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot nest: { group_by: array_column }

1 participant