Skip to content

refactor: migrate mp convert js to objc #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickolas-dimitrakas merged 7 commits into from
Feb 2, 2026
Merged

refactor: migrate mp convert js to objc #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f48792a
refactor: migrate MPConvertJS to objc
nickolas-dimitrakas Jan 30, 2026
feec0e6
fix import issues
nickolas-dimitrakas Jan 30, 2026
1e35402
remove unused var
nickolas-dimitrakas Jan 30, 2026
42a9627
add import to tests
nickolas-dimitrakas Jan 30, 2026
c08ed8b
fix run analyzer error
nickolas-dimitrakas Jan 30, 2026
eec3255
code cleanup + address @jamesnrokt comments
nickolas-dimitrakas Jan 31, 2026
7db551c
Merge branch 'workstation/9.0-Release' into refactor/migrate-MPConver…
nickolas-dimitrakas Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions UnitTests/ObjCTests/MPConvertJSTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
#import <XCTest/XCTest.h>
#import "MPConvertJS.h"
#import "mParticle.h"
#import "MPBaseTestCase.h"
#import "MParticleSwift.h"
Expand Down
12 changes: 8 additions & 4 deletions mParticle-Apple-SDK.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,8 @@
D34286102D419CB800FEC2C8 /* MPUploadSettings.swift in Sources */ = {isa = PBXBuildFile; fileRef = D342860E2D419CA700FEC2C8 /* MPUploadSettings.swift */; };
D356E0252CFE08ED0020898D /* MPResponseConfig.swift in Sources */ = {isa = PBXBuildFile; fileRef = D356E0232CFE08ED0020898D /* MPResponseConfig.swift */; };
D3724C192AE02AF60074CD67 /* mParticle_Apple_SDK_NoLocation.h in Headers */ = {isa = PBXBuildFile; fileRef = D3724C182AE02AF60074CD67 /* mParticle_Apple_SDK_NoLocation.h */; settings = {ATTRIBUTES = (Public, ); }; };
D3CEDACC2CB027E1001B32DF /* MPConvertJS.swift in Sources */ = {isa = PBXBuildFile; fileRef = D3CEDACA2CB027E1001B32DF /* MPConvertJS.swift */; };
D3CEDACB2CB027E1001B32DE /* MPConvertJS.h in Headers */ = {isa = PBXBuildFile; fileRef = D3CEDAC92CB027E1001B32DE /* MPConvertJS.h */; };
D3CEDACC2CB027E1001B32DF /* MPConvertJS.m in Sources */ = {isa = PBXBuildFile; fileRef = D3CEDACA2CB027E1001B32DF /* MPConvertJS.m */; };
/* End PBXBuildFile section */

/* Begin PBXContainerItemProxy section */
Expand Down Expand Up @@ -605,7 +606,8 @@
D3724C182AE02AF60074CD67 /* mParticle_Apple_SDK_NoLocation.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = mParticle_Apple_SDK_NoLocation.h; sourceTree = "<group>"; };
D3B3E2062AE028EC001AB58C /* mParticle_Apple_SDK.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = mParticle_Apple_SDK.h; sourceTree = "<group>"; };
D3BA75152B614E3D008C3C65 /* PrivacyInfo.xcprivacy */ = {isa = PBXFileReference; lastKnownFileType = text.xml; path = PrivacyInfo.xcprivacy; sourceTree = "<group>"; };
D3CEDACA2CB027E1001B32DF /* MPConvertJS.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MPConvertJS.swift; sourceTree = "<group>"; };
D3CEDAC92CB027E1001B32DE /* MPConvertJS.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MPConvertJS.h; sourceTree = "<group>"; };
D3CEDACA2CB027E1001B32DF /* MPConvertJS.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = MPConvertJS.m; sourceTree = "<group>"; };
/* End PBXFileReference section */

/* Begin PBXFileSystemSynchronizedBuildFileExceptionSet section */
Expand Down Expand Up @@ -891,7 +893,8 @@
D34286082D3806CF00FEC2C8 /* MPUserDefaults.swift */,
D342860E2D419CA700FEC2C8 /* MPUploadSettings.swift */,
53A79B0229CDFB1F00E7489F /* MPMessageBuilder.m */,
D3CEDACA2CB027E1001B32DF /* MPConvertJS.swift */,
D3CEDACA2CB027E1001B32DF /* MPConvertJS.m */,
D3CEDAC92CB027E1001B32DE /* MPConvertJS.h */,
53A79B0929CDFB1F00E7489F /* NSDictionary+MPCaseInsensitive.m */,
D356E0232CFE08ED0020898D /* MPResponseConfig.swift */,
53A79B0D29CDFB1F00E7489F /* MPApplication.m */,
Expand Down Expand Up @@ -1279,6 +1282,7 @@
53A79D5529CE23F700E7489F /* MPPersistenceController.h in Headers */,
53A79D5829CE23F700E7489F /* MPIdentityDTO.h in Headers */,
53A79D5929CE23F700E7489F /* MPMessageBuilder.h in Headers */,
D3CEDACB2CB027E1001B32DE /* MPConvertJS.h in Headers */,
53A79D5A29CE23F700E7489F /* MPURLRequestBuilder.h in Headers */,
D3724C192AE02AF60074CD67 /* mParticle_Apple_SDK_NoLocation.h in Headers */,
53A79D5B29CE23F700E7489F /* MPKitContainer.h in Headers */,
Expand Down Expand Up @@ -1584,7 +1588,7 @@
53A79D7729CE23F700E7489F /* MPKitConfiguration.m in Sources */,
35C3DE702F2919B40077C0FD /* MPCCPAConsent.m in Sources */,
53A79D7829CE23F700E7489F /* MPConsentState.m in Sources */,
D3CEDACC2CB027E1001B32DF /* MPConvertJS.swift in Sources */,
D3CEDACC2CB027E1001B32DF /* MPConvertJS.m in Sources */,
53A79D7929CE23F700E7489F /* MPBracket.m in Sources */,
53A79D7A29CE23F700E7489F /* MParticleUserNotification.m in Sources */,
531BCF372B28A23400F5C573 /* MPIdentityCaching.m in Sources */,
Expand Down
1 change: 1 addition & 0 deletions mParticle-Apple-SDK/Ecommerce/MPPromotion.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#import "MPPromotion.h"
#import "MPIConstants.h"
#import "NSDictionary+MPCaseInsensitive.h"
#import "mParticle.h"
#import "MParticleSwift.h"
@import mParticle_Apple_SDK_Swift;

Expand Down
1 change: 1 addition & 0 deletions mParticle-Apple-SDK/Kits/MPEventProjection.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#import "MPEventProjection.h"
#import "MPAttributeProjection.h"
#import "mParticle.h"
#import "MParticleSwift.h"
@import mParticle_Apple_SDK_Swift;

Expand Down
1 change: 1 addition & 0 deletions mParticle-Apple-SDK/MPBackendController.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#import "MPKitContainer.h"
#import "MPURLRequestBuilder.h"
#import "MPIdentityCaching.h"
#import "mParticle.h"
#import "MParticleSwift.h"
#import "MPNetworkCommunication.h"
#if TARGET_OS_IOS == 1
Expand Down
3 changes: 3 additions & 0 deletions mParticle-Apple-SDK/MParticleSession+MParticlePrivate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
#import <Foundation/Foundation.h>
#import "mParticle.h"

@interface MParticleSession ()

- (instancetype)initWithUUID:(NSString *)uuid;
Expand Down
2 changes: 1 addition & 1 deletion mParticle-Apple-SDK/MParticleSession+MParticlePrivate.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#import "MParticleSwift.h"
#import "mParticle.h"
#import "MParticleSession+MParticlePrivate.h"
@import mParticle_Apple_SDK_Swift;

Expand Down
31 changes: 31 additions & 0 deletions mParticle-Apple-SDK/Utils/MPConvertJS.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
#import <Foundation/Foundation.h>
#import "MPCommerceEvent.h"
#import "MPPromotion.h"
#import "MPTransactionAttributes.h"
#import "MPProduct.h"
#import "MPIdentityApiRequest.h"

typedef NS_ENUM(NSUInteger, MPJSCommerceEventAction) {
MPJSCommerceEventActionUnknown = 0,
MPJSCommerceEventActionAddToCart,
MPJSCommerceEventActionRemoveFromCart,
MPJSCommerceEventActionCheckout,
MPJSCommerceEventActionCheckoutOptions,
MPJSCommerceEventActionClick,
MPJSCommerceEventActionViewDetail,
MPJSCommerceEventActionPurchase,
MPJSCommerceEventActionRefund,
MPJSCommerceEventActionAddToWishList,
MPJSCommerceEventActionRemoveFromWishlist
};

@interface MPConvertJS_PRIVATE : NSObject

+ (MPCommerceEvent *)commerceEvent:(NSDictionary *)json;
+ (MPPromotionContainer *)promotionContainer:(NSDictionary *)json;
+ (MPPromotion *)promotion:(NSDictionary *)json;
+ (MPTransactionAttributes *)transactionAttributes:(NSDictionary *)json;
+ (MPProduct *)product:(NSDictionary *)json;
+ (MPIdentityApiRequest *)identityApiRequest:(NSDictionary *)json;

@end
Loading
Loading