-
Notifications
You must be signed in to change notification settings - Fork 72
refactor: migrate mp convert js to objc #537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nickolas-dimitrakas
merged 7 commits into
workstation/9.0-Release
from
refactor/migrate-MPConvertJS-to-objc
Feb 2, 2026
Merged
refactor: migrate mp convert js to objc #537
nickolas-dimitrakas
merged 7 commits into
workstation/9.0-Release
from
refactor/migrate-MPConvertJS-to-objc
Feb 2, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
result of call with @denischilik
📦 SDK Size Impact ReportMeasures how much the SDK adds to an app's size (with-SDK minus without-SDK).
➡️ SDK size impact change is minimal. Raw measurementsTarget branch (workstation/9.0-Release): {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1756,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1672,"sdk_executable_impact_bytes":896,"xcframework_size_kb":6980}This PR: {"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1756,"with_sdk_executable_size_bytes":76360,"sdk_impact_kb":1672,"sdk_executable_impact_bytes":896,"xcframework_size_kb":6848} |
jamesnrokt
reviewed
Jan 30, 2026
denischilik
previously approved these changes
Feb 2, 2026
BrandonStalnaker
previously approved these changes
Feb 2, 2026
7db551c
jamesnrokt
approved these changes
Feb 2, 2026
BrandonStalnaker
approved these changes
Feb 2, 2026
denischilik
approved these changes
Feb 2, 2026
b1eaaf7
into
workstation/9.0-Release
13 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
What Has Changed
MPConvertJS.swiftto objcChecklist
Reference Issue (For employees only. Ignore if you are an outside contributor)