Re-render controls when lastError changes #617
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue that the player may not re-render when an error happens. Here's a scenario we encounter in Daydream App:
errorCountis increased to the value of2, the player is re-rendered as expectederrorCountis again1errorCountis increased to the value of2, the player is not re-rendered, becauseerrorCounthas not changed (it is again2); visually, a users sees a grey screen instead of the stream playback.This PR fixes this issue, because by having
lastErrortimestamp in the equality function, we will always re-render the player if any error happens.Side note re point 3: I'm not 100% sure why we re-render the parent component and why it causes the store to be recreated. I see we're re-rendering all the components every 1s, and that causes (sometimes) the store recreation. @junhyr @gioelecerati you may have some ideas here.
Additional Information