Skip to content

Conversation

@leszko
Copy link
Contributor

@leszko leszko commented Jun 26, 2025

Enable Orchestrator Swapping.

This should be merged when:

  1. This frontend fix is merged and deployed: Re-render controls when lastError changes ui-kit#617
    • Otherwise, a user may see a grey playback screen after the Orchestrator Swap
  2. We sort out the ICE issue with connected/closed state: ai/live: Terminate stream on ICE disconnect. #3629
    • Otherwise, the Orch Swap happens even if the stream was closed correctly, this causes an additional request to a new Orchestraror; not the end of the world, but it can temp eat up our capacity

@github-actions github-actions bot added go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Jun 26, 2025
@codecov
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 31.75357%. Comparing base (7509bd6) to head (cd1a8da).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
server/ai_mediaserver.go 0.00000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3649         +/-   ##
===================================================
+ Coverage   31.74379%   31.75357%   +0.00978%     
===================================================
  Files            156         156                 
  Lines          47351       47349          -2     
===================================================
+ Hits           15031       15035          +4     
+ Misses         31437       31432          -5     
+ Partials         883         882          -1     
Files with missing lines Coverage Δ
server/ai_mediaserver.go 4.51056% <0.00000%> (+0.00864%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7509bd6...cd1a8da. Read the comment docs.

Files with missing lines Coverage Δ
server/ai_mediaserver.go 4.51056% <0.00000%> (+0.00864%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leszko leszko marked this pull request as ready for review June 27, 2025 12:19
@leszko leszko force-pushed the revert-3646-rafal/temp-disable-orch-swapping branch from 7c3b6b9 to cd1a8da Compare July 16, 2025 08:46
@leszko leszko requested review from j0sh and mjh1 July 16, 2025 08:46
@leszko leszko merged commit dc64e3d into master Jul 16, 2025
17 of 18 checks passed
@leszko leszko deleted the revert-3646-rafal/temp-disable-orch-swapping branch July 16, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Issues and PR related to the AI-video branch. go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants