Skip to content

Implement SIMD boolean operations for WASM #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajakubowicz-canva merged 2 commits into from
Jun 26, 2025
Merged

Implement SIMD boolean operations for WASM #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea8f414
implement wasm boolean ops
no-materials Jun 26, 2025
75ed0d2
review: implement additional tests covering `unsigned` & `mask` types
no-materials Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 36 additions & 72 deletions fearless_simd/src/generated/wasm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,7 @@ impl Simd for WasmSimd128 {
}
#[inline(always)]
fn not_i8x16(self, a: i8x16<Self>) -> i8x16<Self> {
/// TODO: If v128 is used, we need to reinterpret it.
todo!()
v128_not(a.into()).simd_into(self)
}
#[inline(always)]
fn add_i8x16(self, a: i8x16<Self>, b: i8x16<Self>) -> i8x16<Self> {
Expand All @@ -180,18 +179,15 @@ impl Simd for WasmSimd128 {
}
#[inline(always)]
fn and_i8x16(self, a: i8x16<Self>, b: i8x16<Self>) -> i8x16<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_and(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn or_i8x16(self, a: i8x16<Self>, b: i8x16<Self>) -> i8x16<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_or(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn xor_i8x16(self, a: i8x16<Self>, b: i8x16<Self>) -> i8x16<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_xor(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn shr_i8x16(self, a: i8x16<Self>, shift: u32) -> i8x16<Self> {
Expand Down Expand Up @@ -254,8 +250,7 @@ impl Simd for WasmSimd128 {
}
#[inline(always)]
fn not_u8x16(self, a: u8x16<Self>) -> u8x16<Self> {
/// TODO: If v128 is used, we need to reinterpret it.
todo!()
v128_not(a.into()).simd_into(self)
}
#[inline(always)]
fn add_u8x16(self, a: u8x16<Self>, b: u8x16<Self>) -> u8x16<Self> {
Expand All @@ -274,18 +269,15 @@ impl Simd for WasmSimd128 {
}
#[inline(always)]
fn and_u8x16(self, a: u8x16<Self>, b: u8x16<Self>) -> u8x16<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_and(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn or_u8x16(self, a: u8x16<Self>, b: u8x16<Self>) -> u8x16<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_or(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn xor_u8x16(self, a: u8x16<Self>, b: u8x16<Self>) -> u8x16<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_xor(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn shr_u8x16(self, a: u8x16<Self>, shift: u32) -> u8x16<Self> {
Expand Down Expand Up @@ -348,23 +340,19 @@ impl Simd for WasmSimd128 {
}
#[inline(always)]
fn not_mask8x16(self, a: mask8x16<Self>) -> mask8x16<Self> {
/// TODO: If v128 is used, we need to reinterpret it.
todo!()
v128_not(a.into()).simd_into(self)
}
#[inline(always)]
fn and_mask8x16(self, a: mask8x16<Self>, b: mask8x16<Self>) -> mask8x16<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_and(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn or_mask8x16(self, a: mask8x16<Self>, b: mask8x16<Self>) -> mask8x16<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_or(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn xor_mask8x16(self, a: mask8x16<Self>, b: mask8x16<Self>) -> mask8x16<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_xor(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn select_mask8x16(
Expand Down Expand Up @@ -392,8 +380,7 @@ impl Simd for WasmSimd128 {
}
#[inline(always)]
fn not_i16x8(self, a: i16x8<Self>) -> i16x8<Self> {
/// TODO: If v128 is used, we need to reinterpret it.
todo!()
v128_not(a.into()).simd_into(self)
}
#[inline(always)]
fn add_i16x8(self, a: i16x8<Self>, b: i16x8<Self>) -> i16x8<Self> {
Expand All @@ -409,18 +396,15 @@ impl Simd for WasmSimd128 {
}
#[inline(always)]
fn and_i16x8(self, a: i16x8<Self>, b: i16x8<Self>) -> i16x8<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_and(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn or_i16x8(self, a: i16x8<Self>, b: i16x8<Self>) -> i16x8<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_or(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn xor_i16x8(self, a: i16x8<Self>, b: i16x8<Self>) -> i16x8<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_xor(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn shr_i16x8(self, a: i16x8<Self>, shift: u32) -> i16x8<Self> {
Expand Down Expand Up @@ -483,8 +467,7 @@ impl Simd for WasmSimd128 {
}
#[inline(always)]
fn not_u16x8(self, a: u16x8<Self>) -> u16x8<Self> {
/// TODO: If v128 is used, we need to reinterpret it.
todo!()
v128_not(a.into()).simd_into(self)
}
#[inline(always)]
fn add_u16x8(self, a: u16x8<Self>, b: u16x8<Self>) -> u16x8<Self> {
Expand All @@ -500,18 +483,15 @@ impl Simd for WasmSimd128 {
}
#[inline(always)]
fn and_u16x8(self, a: u16x8<Self>, b: u16x8<Self>) -> u16x8<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_and(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn or_u16x8(self, a: u16x8<Self>, b: u16x8<Self>) -> u16x8<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_or(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn xor_u16x8(self, a: u16x8<Self>, b: u16x8<Self>) -> u16x8<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_xor(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn shr_u16x8(self, a: u16x8<Self>, shift: u32) -> u16x8<Self> {
Expand Down Expand Up @@ -574,23 +554,19 @@ impl Simd for WasmSimd128 {
}
#[inline(always)]
fn not_mask16x8(self, a: mask16x8<Self>) -> mask16x8<Self> {
/// TODO: If v128 is used, we need to reinterpret it.
todo!()
v128_not(a.into()).simd_into(self)
}
#[inline(always)]
fn and_mask16x8(self, a: mask16x8<Self>, b: mask16x8<Self>) -> mask16x8<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_and(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn or_mask16x8(self, a: mask16x8<Self>, b: mask16x8<Self>) -> mask16x8<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_or(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn xor_mask16x8(self, a: mask16x8<Self>, b: mask16x8<Self>) -> mask16x8<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_xor(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn select_mask16x8(
Expand Down Expand Up @@ -618,8 +594,7 @@ impl Simd for WasmSimd128 {
}
#[inline(always)]
fn not_i32x4(self, a: i32x4<Self>) -> i32x4<Self> {
/// TODO: If v128 is used, we need to reinterpret it.
todo!()
v128_not(a.into()).simd_into(self)
}
#[inline(always)]
fn add_i32x4(self, a: i32x4<Self>, b: i32x4<Self>) -> i32x4<Self> {
Expand All @@ -635,18 +610,15 @@ impl Simd for WasmSimd128 {
}
#[inline(always)]
fn and_i32x4(self, a: i32x4<Self>, b: i32x4<Self>) -> i32x4<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_and(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn or_i32x4(self, a: i32x4<Self>, b: i32x4<Self>) -> i32x4<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_or(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn xor_i32x4(self, a: i32x4<Self>, b: i32x4<Self>) -> i32x4<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_xor(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn shr_i32x4(self, a: i32x4<Self>, shift: u32) -> i32x4<Self> {
Expand Down Expand Up @@ -709,8 +681,7 @@ impl Simd for WasmSimd128 {
}
#[inline(always)]
fn not_u32x4(self, a: u32x4<Self>) -> u32x4<Self> {
/// TODO: If v128 is used, we need to reinterpret it.
todo!()
v128_not(a.into()).simd_into(self)
}
#[inline(always)]
fn add_u32x4(self, a: u32x4<Self>, b: u32x4<Self>) -> u32x4<Self> {
Expand All @@ -726,18 +697,15 @@ impl Simd for WasmSimd128 {
}
#[inline(always)]
fn and_u32x4(self, a: u32x4<Self>, b: u32x4<Self>) -> u32x4<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_and(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn or_u32x4(self, a: u32x4<Self>, b: u32x4<Self>) -> u32x4<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_or(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn xor_u32x4(self, a: u32x4<Self>, b: u32x4<Self>) -> u32x4<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_xor(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn shr_u32x4(self, a: u32x4<Self>, shift: u32) -> u32x4<Self> {
Expand Down Expand Up @@ -800,23 +768,19 @@ impl Simd for WasmSimd128 {
}
#[inline(always)]
fn not_mask32x4(self, a: mask32x4<Self>) -> mask32x4<Self> {
/// TODO: If v128 is used, we need to reinterpret it.
todo!()
v128_not(a.into()).simd_into(self)
}
#[inline(always)]
fn and_mask32x4(self, a: mask32x4<Self>, b: mask32x4<Self>) -> mask32x4<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_and(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn or_mask32x4(self, a: mask32x4<Self>, b: mask32x4<Self>) -> mask32x4<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_or(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn xor_mask32x4(self, a: mask32x4<Self>, b: mask32x4<Self>) -> mask32x4<Self> {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
v128_xor(a.into(), b.into()).simd_into(self)
}
#[inline(always)]
fn select_mask32x4(
Expand Down
22 changes: 0 additions & 22 deletions fearless_simd_gen/src/mk_wasm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,17 +58,6 @@ fn mk_simd_impl(level: Level) -> TokenStream {
}
}
}
OpSig::Unary if method == "not" => {
let args = [quote! { a.into() }];
let expr = Wasm.expr(method, vec_ty, &args);
quote! {
#[inline(always)]
fn #method_ident(self, a: #ty<Self>) -> #ret_ty {
/// TODO: If v128 is used, we need to reinterpret it.
todo!()
}
}
}
OpSig::Unary => {
let args = [quote! { a.into() }];
let expr = if method == "fract" {
Expand All @@ -94,17 +83,6 @@ fn mk_simd_impl(level: Level) -> TokenStream {
}
}
}
OpSig::Binary if method == "xor" || method == "or" || method == "and" => {
let args = [quote! { a.into() }, quote! { b.into() }];
let expr = Wasm.expr(method, vec_ty, &args);
quote! {
#[inline(always)]
fn #method_ident(self, a: #ty<Self>, b: #ty<Self>) -> #ret_ty {
/// TODO: If v128 is used we need to reinterpret it accurately...
todo!()
}
}
}
OpSig::Binary => {
let args = [quote! { a.into() }, quote! { b.into() }];
match method {
Expand Down
Loading