Implement SIMD boolean operations for WASM #21
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the previously TODO-marked SIMD boolean operations for WASM targets.
Changes Made
The reinterpretation logic for these operations was already implemented in the codebase. This PR removes the special conditions that were preventing these operations from being generated through the normal code flow.
Implemented tests for each boolean operation, currently covering the
i8x16vector type to verify correctness of the implementation.Operations Implemented
The following SIMD boolean operations are now available for WASM:
and,or,xor,notTesting
Added test coverage for each operation using the
i8x16vector type.Should I extend the test suite to cover additional vector types, or is the current
i8x16coverage sufficient?