Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions pygit2/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -365,8 +365,8 @@ def raw_name(self) -> bytes:
return ffi.string(self._entry.name)

@cached_property
def raw_value(self) -> bytes:
return ffi.string(self.c_value)
def raw_value(self) -> bytes | None:
return ffi.string(self.c_value) if self.c_value != ffi.NULL else None

@cached_property
def level(self) -> int:
Expand All @@ -379,6 +379,6 @@ def name(self) -> str:
return self.raw_name.decode('utf-8')

@property
def value(self) -> str:
def value(self) -> str | None:
"""The entry's value as a string."""
return self.raw_value.decode('utf-8')
return self.raw_value.decode('utf-8') if self.raw_value is not None else None
29 changes: 29 additions & 0 deletions test/test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,35 @@ def test_iterator(config: Config) -> None:
assert lst['core.bare']


def test_valueless_key_iteration() -> None:
# A valueless key (no `= value`) has a NULL value pointer in libgit2.
# Iterating over such entries must not raise a RuntimeError.
with open(CONFIG_FILENAME, 'w') as new_file:
new_file.write('[section]\n\tvaluelesskey\n\tnormalkey = somevalue\n')

config = Config()
config.add_file(CONFIG_FILENAME, 6)

entries = {entry.name: entry for entry in config}
assert 'section.valuelesskey' in entries
assert 'section.normalkey' in entries


def test_valueless_key_value() -> None:
# A valueless key must expose value=None and raw_value=None.
with open(CONFIG_FILENAME, 'w') as new_file:
new_file.write('[section]\n\tvaluelesskey\n\tnormalkey = somevalue\n')

config = Config()
config.add_file(CONFIG_FILENAME, 6)

entries = {entry.name: entry for entry in config}
assert entries['section.valuelesskey'].raw_value is None
assert entries['section.valuelesskey'].value is None
assert entries['section.normalkey'].raw_value == b'somevalue'
assert entries['section.normalkey'].value == 'somevalue'


def test_parsing() -> None:
assert Config.parse_bool('on')
assert Config.parse_bool('1')
Expand Down
Loading