Fixed RuntimeError when iterating git config entries with valueless keys.#1457
Open
vruyr wants to merge 1 commit intolibgit2:masterfrom
Open
Fixed RuntimeError when iterating git config entries with valueless keys.#1457vruyr wants to merge 1 commit intolibgit2:masterfrom
vruyr wants to merge 1 commit intolibgit2:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1456
Description
Iterating over
repo.configraises aRuntimeErrorif the configuration (including anyinclude.path-sourced files) contains a valueless key — a boolean key written without=, e.g.:[some-section "identifier"] booleanflagTraceback
Root Cause
libgit2 deliberately sets
git_config_entry.value = NULLfor valueless keys. The entry struct is zero-initialized viagit__calloc, and the value field is only populated when a value is actually present (src/libgit2/config_file.c):libgit2's own code handles the NULL case explicitly (same file):
So NULL in
git_config_entry.valueis intentional and documented behavior.pygit2's
_from_ceagerly cachesraw_valueduring iteration (the workaround introduced for #970):And
raw_valuehas no NULL guard:Expected Behavior
Valueless keys should be represented with
value = None(orraw_value = None) rather than raising an exception.Reproduction