Skip to content

Conversation

@strangelookingnerd
Copy link
Contributor

@strangelookingnerd strangelookingnerd commented Dec 16, 2025

See jenkinsci/plugin-pom#1270

Fixes empty arguments for @ParameterizedTest in InjectedTest.
In case no .jelly or .properties file is present, there is nothing to check so the tests can be skipped. This needs some special handling in JUnit.

Testing done

As I was totally unaware of the underlying issue when implementing #1132 I did quite a lot of manual testing now to verify the intended behavior. I successfully ran the failing tests mentioned jenkinsci/plugin-pom#1270 as well.
I actually just learned about the fact that this is causing a test to fail rather than to to be automatically skipped by JUnit. Seems like an odd decision to me but kind of fits in the scheme of how JUnit Jupiter works.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@timja timja merged commit a83ac5b into jenkinsci:master Dec 16, 2025
15 checks passed
@strangelookingnerd strangelookingnerd deleted the fix_empty_arguments branch December 16, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants