Fix empty arguments for parameterized tests #1133
Merged
+24
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See jenkinsci/plugin-pom#1270
Fixes empty arguments for
@ParameterizedTestinInjectedTest.In case no
.jellyor.propertiesfile is present, there is nothing to check so the tests can be skipped. This needs some special handling in JUnit.Testing done
As I was totally unaware of the underlying issue when implementing #1132 I did quite a lot of manual testing now to verify the intended behavior. I successfully ran the failing tests mentioned jenkinsci/plugin-pom#1270 as well.
I actually just learned about the fact that this is causing a test to fail rather than to to be automatically skipped by JUnit. Seems like an odd decision to me but kind of fits in the scheme of how JUnit Jupiter works.
Submitter checklist