-
Notifications
You must be signed in to change notification settings - Fork 22
Added a github action to run the pre-commit hook and display a diff on failure #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
hello-robot-shehab
commented
Jun 12, 2025
- Also changed all the formatters to check and display a diff, instead of apply the fixes.
- Added a Contributing section to the README to explain how to install the pre-commit hook.
…o fix in the codebase right now
|
Pre-commit hook will pass when #91 is merged into this PR. Thanks! Edit: we're removing formatters and linting checks that affect styling. |
|
Merging this PR will always cause the github action to fail, unless we add feature/pre-commit...linting/isort-pass, is this okay with you? We could also just nuke the pre-commit hook entirely if you don't think it's worthwhile, thanks! |
|
I think we can remove isort and keep the rest. My understanding of isort was that it would remove unnecessary imports only. From looking at its docs, it looks like the formatter is tightly integrated, and unnecessary imports are just one of many things it checks for. |
Done, thanks! |
|
Looks like |