-
Notifications
You must be signed in to change notification settings - Fork 110
BE-315: HashQL: Add GraphReadFilter source variant to MIR #8323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bm/be-301-hashql-size-estimation-for-local-variables-and-functions
Are you sure you want to change the base?
Conversation
PR SummaryMedium Risk Overview Updates reification so Adjusts inlining and analysis to reflect the new source: Written by Cursor Bugbot for commit 1003601. This will update automatically on new commits. Configure here. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## bm/be-301-hashql-size-estimation-for-local-variables-and-functions #8323 +/- ##
======================================================================================================
+ Coverage 83.92% 86.93% +3.00%
======================================================================================================
Files 293 154 -139
Lines 43595 21334 -22261
Branches 1178 539 -639
======================================================================================================
- Hits 36588 18546 -18042
+ Misses 6588 2584 -4004
+ Partials 419 204 -215
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2fe1a32 to
6f5ce87
Compare
f97b485 to
5d50f7f
Compare
6f5ce87 to
784af93
Compare
5d50f7f to
58566d5
Compare
784af93 to
f0ffcbc
Compare
58566d5 to
8f66e92
Compare
f0ffcbc to
ec4abcb
Compare
8f66e92 to
1003601
Compare
🌟 What is the purpose of this PR?
Add support for graph read filter closures in MIR by introducing a new
GraphReadFiltersource variant. This allows the compiler to properly handle and optimize filter closures used in graph read operations.🔍 What does this change?
Source::GraphReadFiltervariant to represent MIR generated from filter closures in graph read operationstransform_closuremethod to accept a source parameter instead of constructing it internallyfiltersmethod in the callgraph with direct source type checkingPre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
🛡 What tests cover this?
❓ How to test this?