bug bash: updated test cases

[akanshaaa19]

Summary by CodeRabbit

• Tests
  • Updated test automation across Flow, Staff Management, Interactive Messages, Search, Templates, and Collections features to reflect streamlined UI interaction sequences.
  • Simplified action workflows in test cases by removing intermediary menu interactions.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Update Cypress e2e tests across multiple features to remove intermediate menu interactions (MoreIcon clicks), replacing them with direct action buttons (EditIcon, DeleteIcon, copy-icon) to align with UI component refactoring.

Changes

Cohort / File(s)	Summary
Delete operations standardization cypress/e2e/interactiveMessage/InteractiveMessage.spec.ts, cypress/e2e/search/Search.spec.ts, cypress/e2e/template/SpeedSend.spec.ts, cypress/e2e/waGroup/Collection.spec.ts, cypress/support/collection.js	Remove MoreIcon menu prerequisite click before DeleteIcon; tests now perform delete actions directly instead of opening a dropdown menu first
Flow feature test updates cypress/e2e/flow/Flow.spec.ts	Replace generic additionalButton selector with explicit action-specific icons: edit-icon for edit operations and copy-icon for copy operations
Staff management UI interaction updates cypress/e2e/staffmanagement/StaffManagement.spec.ts	Replace MoreIcon dropdown menu pattern with direct EditIcon clicks; shift from two-step "open menu then edit" workflow to single-step "edit" action

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

• Verify that all MoreIcon clicks have been correctly replaced with direct action clicks across all test files
• Confirm that the new selector paths (EditIcon, DeleteIcon, copy-icon) are accurate and match the updated UI component structure
• Ensure test assertions and control flow logic remain unchanged despite the selector modifications

Possibly related PRs

• Fixes for sprint bug bash ticket #194: Directly related—modifies the same Cypress test files with opposite selector changes, suggesting this PR may be reverting or iterating on that prior work.

Poem

🐰 A rabbit hopped through test-id land,
Where menus fell like autumn sand,
Now buttons gleam both bold and free,
No more MoreIcon mystery!
Direct and swift, the actions go—
Click once, click true, let workflows flow! 🎯

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title is vague and generic, using non-descriptive language ('updated test cases') that does not convey the specific nature of the changes.	Replace with a more specific title that describes the main change, such as 'Refactor UI selectors to use direct action icons instead of menu-based interactions' or 'Replace MoreIcon/additional button interactions with direct icon clicks'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch bug_bash_1126

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

cypress/e2e/staffmanagement/StaffManagement.spec.ts (1)

29-39: Inconsistent data-testid naming across test files.

This file uses EditIcon (PascalCase) while Flow.spec.ts uses edit-icon (kebab-case). Verify this is intentional due to different components, or consider standardizing the selector naming convention across the test suite.

#!/bin/bash
# Description: Check for selector naming patterns across test files
# Looking for variations of edit-icon/EditIcon selectors

echo "=== EditIcon (PascalCase) usage ==="
rg -n "data-testid.*EditIcon" --type=ts

echo ""
echo "=== edit-icon (kebab-case) usage ==="
rg -n "data-testid.*edit-icon" --type=ts

Also applies to: 62-72, 82-82, 95-95, 108-108

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fa5d9f5 and a86034e.

📒 Files selected for processing (7)

• cypress/e2e/flow/Flow.spec.ts (3 hunks)
• cypress/e2e/interactiveMessage/InteractiveMessage.spec.ts (0 hunks)
• cypress/e2e/search/Search.spec.ts (0 hunks)
• cypress/e2e/staffmanagement/StaffManagement.spec.ts (3 hunks)
• cypress/e2e/template/SpeedSend.spec.ts (0 hunks)
• cypress/e2e/waGroup/Collection.spec.ts (0 hunks)
• cypress/support/collection.js (0 hunks)

💤 Files with no reviewable changes (5)

• cypress/support/collection.js
• cypress/e2e/waGroup/Collection.spec.ts
• cypress/e2e/search/Search.spec.ts
• cypress/e2e/interactiveMessage/InteractiveMessage.spec.ts
• cypress/e2e/template/SpeedSend.spec.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: glific (1.18.3-otp-27, 27.3.3)

🔇 Additional comments (6)

cypress/e2e/flow/Flow.spec.ts (3)

148-149: Inconsistent MoreIcon usage pattern.

The test still clicks MoreIcon before clicking edit-icon. Based on the PR objective to remove intermediate menu interactions, verify whether the MoreIcon click on line 148 should also be removed—similar to how line 210 directly clicks copy-icon without a preceding MoreIcon step.

---

198-199: Same inconsistency as above—MoreIcon retained before edit-icon.

This test retains the MoreIcon click before the edit-icon action. Confirm this aligns with the actual UI behavior after the refactor. If the UI now shows the edit icon directly in the row (without a menu), remove line 198.

---

204-214: LGTM—direct copy-icon interaction without MoreIcon.

This correctly implements the pattern of directly clicking the action icon without an intermediate menu step, consistent with the PR's stated objective.

cypress/e2e/staffmanagement/StaffManagement.spec.ts (3)

76-87: LGTM—MoreIcon step removed for direct EditIcon access.

The test now directly clicks EditIcon without an intermediate menu, aligning with the UI refactor.

---

89-100: LGTM—consistent with the direct action pattern.

---

102-112: LGTM—direct navigation without MoreIcon.