fix for failing test cases

[akanshaaa19]

Summary by CodeRabbit

• Tests
  • Refined automated test flows for form actions (deactivate, activate, delete) to follow updated UI interactions.
  • Added an extra UI interaction and a short wait in the form flow to better emulate user behavior and improve stability.
  • Minor test formatting cleanup with no behavior changes.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Replaced generic "More" icon interactions in Cypress WhatsApp form tests with specific icon test IDs for activate/deactivate/delete, and added a 500ms wait in the test flow helper to stabilize an autocomplete interaction; no production code changed.

Changes

Cohort / File(s)	Summary
Test selector updates cypress/e2e/wa_forms/wa_form.spec.ts	Replaced generic MoreIcon-based clicks with direct test IDs: deactivate-icon, activate-icon, and DeleteIcon. Minor formatting tweak in the single-form intercept (removed an empty line).
Flow timing adjustment cypress/support/flow.js	In startFlow, added an extra click on [data-testid="dropdownIcon"], split the autocomplete interaction to click [data-testid="autocomplete-element"], wait(500), then .type('AB') to reduce timing flakiness.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Focus review on mapping updated selectors to current UI test IDs in wa_form.spec.ts.
• Verify the 500ms wait in startFlow is necessary and doesn't mask underlying timing issues.

Possibly related PRs

• added test cases for whatsapp forms #196 — Modifies the same cypress/e2e/wa_forms/wa_form.spec.ts test file; overlapping interactions.
• bug bash: updated test cases #198 — Replaces generic MoreIcon interactions with direct icon test IDs across Cypress tests.

Suggested reviewers

• shijithkjayan

Poem

🐇 I hopped through tests with careful paws,
Swapped vague clicks for clearer claws,
Paused half a beat, then typed with glee,
Now clicks land truer — joy for me! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'fix for failing test cases' is vague and does not specify which test cases are being fixed or what the actual changes are addressing.	Provide a more specific title that describes the actual changes, such as 'Update form control selectors and fix autocomplete flow in tests' to better convey the nature of the modifications.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-tests

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 185ee7a and a72c309.

📒 Files selected for processing (1)

• cypress/support/flow.js (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• cypress/support/flow.js

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: glific (1.18.3-otp-27, 27.3.3)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

cypress/support/flow.js (1)

50-50: Consider waiting for specific UI state instead of hard-coded delay.

The .wait(500) is a timing-based fix that may be brittle across different environments. While this is pragmatic for stabilizing flaky tests, consider waiting for a specific element or network request to appear instead.

For example, if the listbox appears after typing, wait for it explicitly:

-      cy.get('[data-testid="autocomplete-element"]').click().type('AB').wait(500);
+      cy.get('[data-testid="autocomplete-element"]').click().type('AB');
+      cy.get('ul[role="listbox"]').should('be.visible');
       cy.get('ul[role="listbox"]').find('li').contains('AB Test Workflow').click({ force: true });

cypress/e2e/wa_forms/wa_form.spec.ts (1)

309-316: LGTM! Direct selector improves test clarity.

The change to use the direct DeleteIcon selector aligns with the updated UI pattern and makes the test more maintainable.

Minor nitpick: Consider using .eq(0) instead of .first() for consistency with lines 294 and 303:

-    cy.get('[data-testid="DeleteIcon"]').first().click();
+    cy.get('[data-testid="DeleteIcon"]').eq(0).click();

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7d02ce6 and d3f52ea.

📒 Files selected for processing (2)

• cypress/e2e/wa_forms/wa_form.spec.ts (2 hunks)
• cypress/support/flow.js (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: glific (1.18.3-otp-27, 27.3.3)

🔇 Additional comments (3)

cypress/e2e/wa_forms/wa_form.spec.ts (2)

293-300: LGTM! Direct selector improves test clarity.

The change from the generic MoreIcon pattern to the specific deactivate-icon selector makes the test more explicit and resilient to UI changes.

---

302-307: LGTM! Direct selector improves test clarity.

The change to use the specific activate-icon selector makes the test more explicit and aligns with the UI update.

cypress/support/flow.js (1)

8-9: No action required – no UI pattern inconsistency exists.

The deleteFlow command correctly uses the MoreIcon → DeleteIcon pattern, which matches how wa_form.spec.ts deletes forms (line 310). The deactivate-icon and activate-icon selectors in wa_form.spec.ts are for status management, not deletion, and are unrelated to the deletion flow pattern.

Likely an incorrect or invalid review comment.