chore: add info for working with intrinsics to AGENTS.md#768
chore: add info for working with intrinsics to AGENTS.md#768psschwei wants to merge 2 commits intogenerative-computing:mainfrom
Conversation
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
|
cc @generative-computing/mellea-intrinsics |
jakelorocco
left a comment
There was a problem hiding this comment.
I think this is a good thing to add. I have a few vibe-based thoughts. Feel free to disagree with them.
AGENTS.md
Outdated
| ## 13. Working with Intrinsics | ||
|
|
||
| Intrinsics are specialized LoRA adapters hosted on Hugging Face that add task-specific capabilities (RAG evaluation, safety checks, calibration, etc.) to Granite models. | ||
|
|
||
| **⚠️ Before writing code that uses an intrinsic, fetch its README from Hugging Face.** Each README contains the authoritative specification for input format, output format, intended use, and examples. Do not guess these details. |
There was a problem hiding this comment.
I worry that this piece of things might be too generic to regular intrinsics and not utilizing them in Mellea. The following is just based off vibes:
- I would maybe preface with the how to use in Mellea stuff (the project resources below but maybe with more details here).
- I would phrase this current working with intrinsics section as something like "how to add new intrinsics".
Since we utilize the "granite-common" formatters for intrinsics, the agent shouldn't actually need to know how to modify the context / messages, the library should do that for us. It just needs to know whether to call the high-level / convenience wrappers or the regular usage.
There was a problem hiding this comment.
Those are fair points. Referring to the model cards was something the intrinsics team suggested, but I believe that was mostly around intended usage and examples (in a previous PR we had used them in a counterproductive way). Let me revise a bit
Signed-off-by: Paul S. Schweigert <paul@paulschweigert.com>
There was a problem hiding this comment.
Not tested, but very much support the principle of better agent instructions.
However I wonder if this would be better as a skill in .agents/skills since it's targeted at something quite specific. That would keep the context down for general agent interactions. We'd just put an entry into AGENTS.md with something like
## 13. Intrinsics
Working with intrinsics (LoRA adapters for RAG, safety, calibration)? Use `/intrinsics-guide`.
I think much of the rest guide is about process - and common to most tasks. Though there may be errors equally relevant to consider for a skill - it's just we only just started adding them ;-)
No objections if you want to merge - we can skillify after
The idea was to get this in as a quick tactical fix, as the lack of intrinsics info was causing real problems. Turns out it didn't get in quickly 😄 I'd still be inclined to merge this and then do a update/refactor of AGENTS.md more broadly (it's also probably due an update, I had one open in #693 but that also wasn't merged) to take in the latest changes. |
Misc PR
Type of PR
Description
Adds information for agents when working with intrinsics in this repo
Testing