Skip to content

Conversation

@azeey
Copy link
Contributor

@azeey azeey commented Jan 30, 2026

🦟 Bug fix

Summary

benchmark::internal::Benchmark was deprecated in google/benchmark#2101 which was released as 1.9.5

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

`benchmark::internal::Benchmark` was deprecated in
google/benchmark#2101 which was released as
1.9.5

Signed-off-by: Addisu Z. Taddese <[email protected]>
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Jan 31, 2026
@azeey azeey merged commit 8edb19f into gazebosim:main Jan 31, 2026
14 checks passed
@azeey azeey deleted the fix_benchmark_deprecation branch January 31, 2026 03:24
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Jan 31, 2026
@azeey
Copy link
Contributor Author

azeey commented Jan 31, 2026

@Mergifyio backport gz-sim10 gz-sim9 gz-sim8 ign-gazebo6

@mergify
Copy link
Contributor

mergify bot commented Jan 31, 2026

backport gz-sim10 gz-sim9 gz-sim8 ign-gazebo6

✅ Backports have been created

Details

Cherry-pick of 8edb19f has failed:

On branch mergify/bp/ign-gazebo6/pr-3296
Your branch is up to date with 'origin/ign-gazebo6'.

You are currently cherry-picking commit 8edb19f8.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   test/benchmark/each.cc

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test/benchmark/CMakeLists.txt

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

mergify bot pushed a commit that referenced this pull request Jan 31, 2026
`benchmark::internal::Benchmark` was deprecated in
google/benchmark#2101 which was released as
1.9.5

Signed-off-by: Addisu Z. Taddese <[email protected]>
(cherry picked from commit 8edb19f)
mergify bot pushed a commit that referenced this pull request Jan 31, 2026
`benchmark::internal::Benchmark` was deprecated in
google/benchmark#2101 which was released as
1.9.5

Signed-off-by: Addisu Z. Taddese <[email protected]>
(cherry picked from commit 8edb19f)
mergify bot pushed a commit that referenced this pull request Jan 31, 2026
`benchmark::internal::Benchmark` was deprecated in
google/benchmark#2101 which was released as
1.9.5

Signed-off-by: Addisu Z. Taddese <[email protected]>
(cherry picked from commit 8edb19f)
mergify bot pushed a commit that referenced this pull request Jan 31, 2026
`benchmark::internal::Benchmark` was deprecated in
google/benchmark#2101 which was released as
1.9.5

Signed-off-by: Addisu Z. Taddese <[email protected]>
(cherry picked from commit 8edb19f)

# Conflicts:
#	test/benchmark/CMakeLists.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants