Fix SDF generation (world saving) when schemed URIs are used for resource URIs #3286
+447
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing a crash where the callbacks that were registered in an earlier test were being called in a later test. Since the pointers accessed in the callbacks have long been destroyed, a memory corruption occurs. Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
This especially affects models spawned from string Signed-off-by: Addisu Z. Taddese <[email protected]>
azeey
added
needs upstream release
9 tasks
This was referenced Jan 28, 2026
iche033
added a commit
that referenced
this pull request
Jan 28, 2026
Signed-off-by: Ian Chen <[email protected]>
9 tasks
Contributor
Author
|
@osrf-jenkins run tests please |
azeey
removed
the
needs upstream release
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
SDF generation was broken when schemed URIs (e.g
model://orpackage://) were used for resource URIs such as meshes. Models spawned from string URDF also contained a<urdf-string>string inside the generated file paths.7727978 Adds failing tests
0012fe4 Clears findfile callbacks to avoid lifetime mismatches.
This was causing a crash where the callbacks that were registered
in an earlier test were being called in a later test. Since the
pointers accessed in the callbacks have long been destroyed,
a memory corruption occurs.
Needs: gazebosim/gz-common#754
Checklist
codecheckpassed (See contributing)Generated-by: Remove this if GenAI was not used.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.