Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app_dart/lib/src/service/firestore/unified_check_run.dart
Original file line number Diff line number Diff line change
Expand Up @@ -583,6 +583,7 @@ final class UnifiedCheckRun {
// completed.
} else if (state.status == TaskStatus.inProgress) {
presubmitJob.startTime = state.startTime!;
presubmitJob.buildNumber = state.buildNumber;
// If the job is not completed, update the status.
if (!status.isComplete) {
status = state.status;
Expand Down
30 changes: 30 additions & 0 deletions app_dart/test/service/firestore/unified_check_run_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,36 @@ void main() {

expect(result.result, PresubmitGuardConclusionResult.missing);
});
test('updates check status and build number on inProgress', () async {
final state = const PresubmitJobState(
jobName: 'linux',
status: TaskStatus.inProgress,
attemptNumber: 1,
startTime: 2000,
buildNumber: 456,
);

final result = await UnifiedCheckRun.markConclusion(
firestoreService: firestoreService,
guardId: guardId,
state: state,
);

expect(result.result, PresubmitGuardConclusionResult.ok);

final checkDoc = await PresubmitJob.fromFirestore(
firestoreService,
PresubmitJobId(
slug: slug,
checkRunId: 123,
jobName: 'linux',
attemptNumber: 1,
),
);
expect(checkDoc.status, TaskStatus.inProgress);
expect(checkDoc.startTime, 2000);
expect(checkDoc.buildNumber, 456);
});
});
group('reInitializeFailedChecks', () {
late PresubmitGuardId fusionGuardId;
Expand Down
Loading