Store buildNumber in presubmitJob on inProgress event#5008
Open
Store buildNumber in presubmitJob on inProgress event#5008
buildNumber in presubmitJob on inProgress event#5008Conversation
ievdokdm
added
autosubmit
Contributor
|
🤖 Hi @ievdokdm, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
This pull request correctly adds the storage of the buildNumber in the presubmitJob record during the inProgress state. This ensures that the build number is available for monitoring or debugging purposes as soon as the build starts.
🔍 General Feedback
- The change is surgical and consistent with the existing logic for handling job completion.
- I've suggested adding a unit test to verify this behavior and prevent regressions in the future.
- The use of
state.buildNumberis safe because thePresubmitJob.buildNumbersetter correctly handles nullable integers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Store
buildNumberinpresubmitJoboninProgresseventFix: flutter/flutter#184371