Skip to content
This repository was archived by the owner on May 30, 2025. It is now read-only.
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions execution.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package execution

Check failure on line 1 in execution.go

View workflow job for this annotation

GitHub Actions / lint / golangci-lint

: # github.com/rollkit/go-execution-evm [github.com/rollkit/go-execution-evm.test]

import (
"context"
Expand Down Expand Up @@ -29,7 +29,7 @@
)

// Ensure EngineAPIExecutionClient implements the execution.Execute interface
var _ execution.Executor = (*PureEngineClient)(nil)

Check failure on line 32 in execution.go

View workflow job for this annotation

GitHub Actions / lint / golangci-lint

cannot use (*PureEngineClient)(nil) (value of type *PureEngineClient) as "github.com/rollkit/rollkit/core/execution".Executor value in variable declaration: *PureEngineClient does not implement "github.com/rollkit/rollkit/core/execution".Executor (wrong type for method ExecuteTxs)

// PureEngineClient represents a client that interacts with an Ethereum execution engine
// through the Engine API. It manages connections to both the engine and standard Ethereum
Expand Down Expand Up @@ -139,7 +139,7 @@
if err != nil {
return nil, 0, fmt.Errorf("failed to get txs: %w", err)
}
return c.ExecuteTxs(ctx, payload, 1, genesisTime, stateRoot[:])
return c.ExecuteTxs(ctx, payload, 1, genesisTime, stateRoot[:], nil)
}

// GetTxs retrieves transactions from the current execution payload
Expand Down Expand Up @@ -209,7 +209,7 @@
}

// ExecuteTxs executes the given transactions at the specified block height and timestamp
func (c *PureEngineClient) ExecuteTxs(ctx context.Context, txs [][]byte, blockHeight uint64, timestamp time.Time, prevStateRoot []byte) (updatedStateRoot []byte, maxBytes uint64, err error) {
func (c *PureEngineClient) ExecuteTxs(ctx context.Context, txs [][]byte, blockHeight uint64, timestamp time.Time, prevStateRoot []byte, metadata map[string]interface{}) (updatedStateRoot []byte, maxBytes uint64, err error) {
// special handling of block 1 (rollkit expects this to be genesis block)
if blockHeight == 1 && len(txs) == 0 {
_, stateRoot, gasLimit, err := c.getBlockInfo(ctx, blockHeight)
Expand Down
Loading